* [PATCH net-next] Remove the redundant skb->dev initialization in ip6_fragment
@ 2017-06-10 19:35 Chenbo Feng
2017-06-10 20:25 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Chenbo Feng @ 2017-06-10 19:35 UTC (permalink / raw)
To: netdev, David Miller; +Cc: Lorenzo Colitti, Eric Dumazet, Chenbo Feng
From: Chenbo Feng <fengc@google.com>
After moves the skb->dev and skb->protocol initialization into
ip6_output, setting the skb->dev inside ip6_fragment is unnecessary.
Fixes: 97a7a37a7b7b("ipv6: Initial skb->dev and skb->protocol in ip6_output")
Signed-off-by: Chenbo Feng <fengc@google.com>
---
net/ipv6/ip6_output.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c
index 02cd44f..0d6f3b6 100644
--- a/net/ipv6/ip6_output.c
+++ b/net/ipv6/ip6_output.c
@@ -869,7 +869,6 @@ int ip6_fragment(struct net *net, struct sock *sk, struct sk_buff *skb,
if (skb->sk && dst_allfrag(skb_dst(skb)))
sk_nocaps_add(skb->sk, NETIF_F_GSO_MASK);
- skb->dev = skb_dst(skb)->dev;
icmpv6_send(skb, ICMPV6_PKT_TOOBIG, 0, mtu);
err = -EMSGSIZE;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] Remove the redundant skb->dev initialization in ip6_fragment
2017-06-10 19:35 [PATCH net-next] Remove the redundant skb->dev initialization in ip6_fragment Chenbo Feng
@ 2017-06-10 20:25 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-06-10 20:25 UTC (permalink / raw)
To: chenbofeng.kernel; +Cc: netdev, lorenzo, edumazet, fengc
From: Chenbo Feng <chenbofeng.kernel@gmail.com>
Date: Sat, 10 Jun 2017 12:35:38 -0700
> From: Chenbo Feng <fengc@google.com>
>
> After moves the skb->dev and skb->protocol initialization into
> ip6_output, setting the skb->dev inside ip6_fragment is unnecessary.
>
> Fixes: 97a7a37a7b7b("ipv6: Initial skb->dev and skb->protocol in ip6_output")
> Signed-off-by: Chenbo Feng <fengc@google.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-10 20:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-10 19:35 [PATCH net-next] Remove the redundant skb->dev initialization in ip6_fragment Chenbo Feng
2017-06-10 20:25 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).