From: Andrew Lunn <andrew@lunn.ch>
To: "Mintz, Yuval" <Yuval.Mintz@cavium.com>
Cc: Salil Mehta <salil.mehta@huawei.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"yisen.zhuang@huawei.com" <yisen.zhuang@huawei.com>,
"huangdaode@hisilicon.com" <huangdaode@hisilicon.com>,
"lipeng321@huawei.com" <lipeng321@huawei.com>,
"mehta.salil.lnk@gmail.com" <mehta.salil.lnk@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linuxarm@huawei.com" <linuxarm@huawei.com>
Subject: Re: [PATCH net-next 8/9] net: hns3: Add support of debugfs interface to HNS3 driver
Date: Sat, 10 Jun 2017 18:35:35 +0200 [thread overview]
Message-ID: <20170610163535.GC26740@lunn.ch> (raw)
In-Reply-To: <BY2PR0701MB2005750A49D78C63B4B4A6B18DCF0@BY2PR0701MB2005.namprd07.prod.outlook.com>
On Sat, Jun 10, 2017 at 12:51:57PM +0000, Mintz, Yuval wrote:
> > This adds the support of the debugfs interface to the driver for debugging
> > purposes.
>
> > +const struct hclge_support_cmd support_cmd[] = {
> > + {"send cmd", 8, hclge_dbg_send,
> > + "opcode flag data0 data1 data2 data3 data4 data5"},
> > + {"help", 4, hclge_dbg_usage, "no option"}, };
>
> Is there an actual description of what this does? Or is it simply a huge backdoor?
It looks like a huge backdoor to the chip.
It is O.K. to have such a patch internally for your own development
work, but it should not be submitted for mainline.
NACK
Andrew
next prev parent reply other threads:[~2017-06-10 16:35 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-10 3:46 [PATCH net-next 0/9] Hisilicon Network Subsystem 3 Ethernet Driver Salil Mehta
2017-06-10 3:46 ` [PATCH net-next 1/9] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC Salil Mehta
2017-06-10 12:43 ` Mintz, Yuval
2017-06-13 17:08 ` Salil Mehta
2017-06-14 8:04 ` Mintz, Yuval
2017-06-17 12:00 ` Salil Mehta
2017-06-10 3:46 ` [PATCH net-next 2/9] net: hns3: Add support of the HNAE3 framework Salil Mehta
2017-06-10 3:46 ` [PATCH net-next 3/9] net: hns3: Add HNS3 IMP(Integrated Mgmt Proc) Cmd Interface Support Salil Mehta
2017-06-10 3:46 ` [PATCH net-next 4/9] net: hns3: Add HNS3 Acceleration Engine & Compatibility Layer Support Salil Mehta
2017-06-10 3:46 ` [PATCH net-next 5/9] net: hns3: Add support of TX Scheduler & Shaper to HNS3 driver Salil Mehta
2017-06-10 3:46 ` [PATCH net-next 6/9] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC Salil Mehta
2017-06-10 19:04 ` Florian Fainelli
2017-06-11 2:43 ` Andrew Lunn
2017-06-13 20:47 ` Salil Mehta
2017-06-13 21:15 ` Andrew Lunn
2017-06-13 21:37 ` Salil Mehta
2017-06-13 22:40 ` Andrew Lunn
2017-06-13 23:01 ` Salil Mehta
2017-06-14 1:10 ` Andrew Lunn
2017-06-17 11:10 ` Salil Mehta
2017-06-10 3:46 ` [PATCH net-next 7/9] net: hns3: Add Ethtool support to HNS3 driver Salil Mehta
2017-06-10 3:46 ` [PATCH net-next 8/9] net: hns3: Add support of debugfs interface " Salil Mehta
2017-06-10 12:51 ` Mintz, Yuval
2017-06-10 16:35 ` Andrew Lunn [this message]
2017-06-13 17:16 ` Salil Mehta
2017-06-13 17:14 ` Salil Mehta
2017-06-10 3:46 ` [PATCH net-next 9/9] net: hns3: Add HNS3 driver to kernel build framework & MAINTAINERS Salil Mehta
2017-06-11 13:41 ` kbuild test robot
2017-06-11 13:41 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170610163535.GC26740@lunn.ch \
--to=andrew@lunn.ch \
--cc=Yuval.Mintz@cavium.com \
--cc=davem@davemloft.net \
--cc=huangdaode@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lipeng321@huawei.com \
--cc=mehta.salil.lnk@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).