From: David Miller <davem@davemloft.net>
To: yuval.shaia@oracle.com
Cc: michael.chan@broadcom.com, f.fainelli@gmail.com,
siva.kallam@broadcom.com, prashant@broadcom.com,
madalin.bucur@nxp.com, leoli@freescale.com,
sebastian.hesselbarth@gmail.com,
sergei.shtylyov@cogentembedded.com, grygorii.strashko@ti.com,
w-kwok2@ti.com, m-karicheri2@ti.com, andrew@lunn.ch,
woojung.huh@microchip.com, UNGLinuxDriver@microchip.com,
vivien.didelot@savoirfairelinux.com, arnd@arndb.de,
tremyfr@gmail.com, jarod@redhat.com, horms+renesas@verge.net.au,
kazuya.mizuguchi.ks@renesas.com, dan.carpenter@oracle.com,
niklas.soderlund+renesas@ragnatech.se, johan@kernel.org,
masaru.nagai.vx@renesas.com, geert+renesas@glider.be,
laurent.pinchart@ideasonboard.com, chris.brandt@renesas.com,
ivan.khoronzhuk@linaro.org, mugunthanvnm@ti.com,
netdev@vger.kernel.org, linux-arm-kernel
Subject: Re: [PATCH v2] net: phy: Make phy_ethtool_ksettings_get return void
Date: Mon, 12 Jun 2017 10:59:05 -0400 (EDT) [thread overview]
Message-ID: <20170612.105905.1031273319008486521.davem@davemloft.net> (raw)
In-Reply-To: <20170612.102525.1159274040679939960.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Mon, 12 Jun 2017 10:25:25 -0400 (EDT)
> From: Yuval Shaia <yuval.shaia@oracle.com>
> Date: Mon, 12 Jun 2017 17:15:08 +0300
>
>> Make return value void since function never return meaningfull value
>>
>> Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
>> Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> ---
>> v0 ->v1:
>> * These files were missing in v0
>> * drivers/net/ethernet/renesas/ravb_main.c
>> * drivers/net/ethernet/renesas/sh_eth.c
>> * drivers/net/ethernet/ti/netcp_ethss.c
>> * Add Acked-by: Sergei Shtylyov
>> v1 -> v2:
>> * Adjust to net-next tree
>
> Applied, thank you.
Reverted, please test your build properly:
drivers/net/ethernet/apm/xgene/xgene_enet_ethtool.c: In function ‘xgene_get_link_ksettings’:
drivers/net/ethernet/apm/xgene/xgene_enet_ethtool.c:134:10: error: void value not ignored as it ought to be
return phy_ethtool_ksettings_get(phydev, cmd);
^
drivers/net/ethernet/apm/xgene/xgene_enet_ethtool.c:140:11: error: void value not ignored as it ought to be
return phy_ethtool_ksettings_get(phydev, cmd);
^
scripts/Makefile.build:302: recipe for target 'drivers/net/ethernet/apm/xgene/xgene_enet_ethtool.o' failed
next prev parent reply other threads:[~2017-06-12 14:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-12 14:15 [PATCH v2] net: phy: Make phy_ethtool_ksettings_get return void Yuval Shaia
2017-06-12 14:25 ` David Miller
2017-06-12 14:59 ` David Miller [this message]
[not found] ` <20170612141508.29229-1-yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-06-12 18:13 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170612.105905.1031273319008486521.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=chris.brandt@renesas.com \
--cc=dan.carpenter@oracle.com \
--cc=f.fainelli@gmail.com \
--cc=geert+renesas@glider.be \
--cc=grygorii.strashko@ti.com \
--cc=horms+renesas@verge.net.au \
--cc=ivan.khoronzhuk@linaro.org \
--cc=jarod@redhat.com \
--cc=johan@kernel.org \
--cc=kazuya.mizuguchi.ks@renesas.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=leoli@freescale.com \
--cc=m-karicheri2@ti.com \
--cc=madalin.bucur@nxp.com \
--cc=masaru.nagai.vx@renesas.com \
--cc=michael.chan@broadcom.com \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=prashant@broadcom.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=siva.kallam@broadcom.com \
--cc=tremyfr@gmail.com \
--cc=vivien.didelot@savoirfairelinux.com \
--cc=w-kwok2@ti.com \
--cc=woojung.huh@microchip.com \
--cc=yuval.shaia@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox