* [PATCH net] proc: snmp6: Use correct type in memset
@ 2017-06-12 8:06 Christian Perle
2017-06-12 13:53 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Christian Perle @ 2017-06-12 8:06 UTC (permalink / raw)
To: davem; +Cc: netdev, hejianet
Reading /proc/net/snmp6 yields bogus values on 32 bit kernels.
Use "u64" instead of "unsigned long" in sizeof().
Fixes: 4a4857b ("proc: Reduce cache miss in snmp6_seq_show")
Signed-off-by: Christian Perle <christian.perle@secunet.com>
---
net/ipv6/proc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv6/proc.c b/net/ipv6/proc.c
index cc8e3ae..e88bcb8 100644
--- a/net/ipv6/proc.c
+++ b/net/ipv6/proc.c
@@ -219,7 +219,7 @@ static void snmp6_seq_show_item64(struct seq_file *seq, void __percpu *mib,
u64 buff64[SNMP_MIB_MAX];
int i;
- memset(buff64, 0, sizeof(unsigned long) * SNMP_MIB_MAX);
+ memset(buff64, 0, sizeof(u64) * SNMP_MIB_MAX);
snmp_get_cpu_field64_batch(buff64, itemlist, mib, syncpoff);
for (i = 0; itemlist[i].name; i++)
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net] proc: snmp6: Use correct type in memset
2017-06-12 8:06 [PATCH net] proc: snmp6: Use correct type in memset Christian Perle
@ 2017-06-12 13:53 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-06-12 13:53 UTC (permalink / raw)
To: christian.perle; +Cc: netdev, hejianet
From: Christian Perle <christian.perle@secunet.com>
Date: Mon, 12 Jun 2017 10:06:57 +0200
> Reading /proc/net/snmp6 yields bogus values on 32 bit kernels.
> Use "u64" instead of "unsigned long" in sizeof().
>
> Fixes: 4a4857b ("proc: Reduce cache miss in snmp6_seq_show")
Please use 12 significant digits of SHA1-ID in Fixes: tags, I fixed
it up for you this time.
> Signed-off-by: Christian Perle <christian.perle@secunet.com>
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-12 13:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-12 8:06 [PATCH net] proc: snmp6: Use correct type in memset Christian Perle
2017-06-12 13:53 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).