From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jiri Pirko <jiri@resnulli.us>
Subject: Re: [PATCH net-next v10 3/4] net sched actions: dump more than
 TCA_ACT_MAX_PRIO actions per batch
Date: Mon, 12 Jun 2017 13:47:51 +0200
Message-ID: <20170612114751.GC1993@nanopsycho>
References: <1497182026-11594-1-git-send-email-jhs@emojatatu.com>
 <1497182026-11594-4-git-send-email-jhs@emojatatu.com>
 <20170611141303.GC1896@nanopsycho.orion>
 <fbf09ea1-36ee-69b1-74b0-ac436fff86ad@mojatatu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: davem@davemloft.net, netdev@vger.kernel.org,
        xiyou.wangcong@gmail.com, eric.dumazet@gmail.com,
        simon.horman@netronome.com, mrv@mojatatu.com
To: Jamal Hadi Salim <jhs@mojatatu.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wr0-f193.google.com ([209.85.128.193]:34248 "EHLO
        mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752653AbdFLLry (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 12 Jun 2017 07:47:54 -0400
Received: by mail-wr0-f193.google.com with SMTP id u101so21430479wrc.1
        for <netdev@vger.kernel.org>; Mon, 12 Jun 2017 04:47:54 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <fbf09ea1-36ee-69b1-74b0-ac436fff86ad@mojatatu.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Mon, Jun 12, 2017 at 01:16:05PM CEST, jhs@mojatatu.com wrote:
>On 17-06-11 10:13 AM, Jiri Pirko wrote:
>> Sun, Jun 11, 2017 at 01:53:45PM CEST, jhs@mojatatu.com wrote:
>[..]
>> > @@ -1168,14 +1185,24 @@ static int tc_dump_action(struct sk_buff *skb, struct netlink_callback *cb)
>> > 	if (a_o == NULL)
>> > 		return 0;
>> > 
>> > +	if (tb[TCA_ROOT_FLAGS])
>> > +		nla_memcpy(&select_flags, tb[TCA_ROOT_FLAGS],
>> > +			   sizeof(select_flags));
>> 
>> Please introduce a helper for this attr type in patch 1:
>> 
>> u32 select_flags;
>> 
>> select_flags = nla_get_flag_bits_values(tb[TCA_ROOT_FLAGS])
>> 
>
>This also is not useful.
>It happens to be ok for this use case but not for the
>general case. i.e.
>We need to get the whole struct not just the values
>and use the selector to pick what bits are affected.
>Example if bit X is set to 1 in selector and bit X in value
>is 0, then we set the kernel's bit X to 0.

Sure, have another helper for selector then.
Or, you can have:

	struct nla_flag_bits *fb;
	fb = nla_get_flag_bits(tb[TCA_ROOT_FLAGS]);

Or all 3 helpers. My point is, it is a specific netlink attribute with
specific format, it should have get/put helpers.