* [PATCH net-next] ibmvnic: Remove netdev notify for failover resets
@ 2017-06-13 0:47 Nathan Fontenot
2017-06-13 17:00 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Nathan Fontenot @ 2017-06-13 0:47 UTC (permalink / raw)
To: netdev
When handling a driver reset due to a failover of the backing
server on the vios, doing the netdev_notify_peers() can cause
network traffic to stall or halt. Remove the netdev notify call
for failover resets.
Signed-off-by: Nathan Fontenot <nfont@linux.vnet.ibm.com>
---
drivers/net/ethernet/ibm/ibmvnic.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
index 7d84e20..1c647c0 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -1364,7 +1364,9 @@ static int do_reset(struct ibmvnic_adapter *adapter,
for (i = 0; i < adapter->req_rx_queues; i++)
napi_schedule(&adapter->napi[i]);
- netdev_notify_peers(netdev);
+ if (adapter->reset_reason != VNIC_RESET_FAILOVER)
+ netdev_notify_peers(netdev);
+
return 0;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] ibmvnic: Remove netdev notify for failover resets
2017-06-13 0:47 [PATCH net-next] ibmvnic: Remove netdev notify for failover resets Nathan Fontenot
@ 2017-06-13 17:00 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-06-13 17:00 UTC (permalink / raw)
To: nfont; +Cc: netdev
From: Nathan Fontenot <nfont@linux.vnet.ibm.com>
Date: Mon, 12 Jun 2017 20:47:45 -0400
> When handling a driver reset due to a failover of the backing
> server on the vios, doing the netdev_notify_peers() can cause
> network traffic to stall or halt. Remove the netdev notify call
> for failover resets.
>
> Signed-off-by: Nathan Fontenot <nfont@linux.vnet.ibm.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-13 17:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-13 0:47 [PATCH net-next] ibmvnic: Remove netdev notify for failover resets Nathan Fontenot
2017-06-13 17:00 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).