From: David Miller <davem@davemloft.net>
To: brakmo@fb.com
Cc: netdev@vger.kernel.org, kernel-team@fb.com, bmatheny@fb.com,
ast@fb.com, daniel@iogearbox.net, dsa@cumulusnetworks.com
Subject: Re: [RFC PATCH net-next 07/15] bpf: Add setsockopt helper function to bpf
Date: Tue, 13 Jun 2017 17:16:41 -0400 (EDT) [thread overview]
Message-ID: <20170613.171641.971171683474923625.davem@davemloft.net> (raw)
In-Reply-To: <20170613180004.3008403-8-brakmo@fb.com>
From: Lawrence Brakmo <brakmo@fb.com>
Date: Tue, 13 Jun 2017 10:59:56 -0700
> +BPF_CALL_5(bpf_setsockopt, struct bpf_socket_ops_kern *, bpf_socket,
> + int, level, int, optname, char *, optval, int, optlen)
> +{
> + int val;
> + int ret = 0;
> + struct sock *sk = bpf_socket->sk;
Longest to shortest line for variable declarations please.
Also, throughout your submission make sure you indent multi-line
function declarations and definitions properly. It needs to be:
return_type function_name(type1 arg1, type2 arg2, type3 arg3,
type4 arg4, type5 arg5)
such that "type4 arg4" starts precisely at the first column after
the openning parenthesis of the first line. You must use the
appropriate number of TAB then SPACE characters necessary to
achieve this.
Thank you.
next prev parent reply other threads:[~2017-06-13 21:16 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-13 17:59 RFC PATCH net-next 00/15] bpf: Add new SOCKET_OPS program type Lawrence Brakmo
2017-06-13 17:59 ` [RFC PATCH net-next 01/15] net: BPF support for socket ops Lawrence Brakmo
2017-06-13 21:12 ` David Miller
2017-06-13 17:59 ` [RFC PATCH net-next 02/15] bpf: program to load socketops BPF programs Lawrence Brakmo
2017-06-13 17:59 ` [RFC PATCH net-next 03/15] bpf: Support for per connection SYN/SYN-ACK RTOs Lawrence Brakmo
2017-06-13 17:59 ` [RFC PATCH net-next 04/15] bpf: Sample bpf program to set " Lawrence Brakmo
2017-06-13 21:13 ` David Miller
2017-06-13 17:59 ` [RFC PATCH net-next 05/15] bpf: Support for setting initial receive window Lawrence Brakmo
2017-06-13 21:14 ` David Miller
2017-06-13 17:59 ` [RFC PATCH net-next 06/15] bpf: Sample bpf program to set initial window Lawrence Brakmo
2017-06-13 21:14 ` David Miller
2017-06-13 17:59 ` [RFC PATCH net-next 07/15] bpf: Add setsockopt helper function to bpf Lawrence Brakmo
2017-06-13 21:16 ` David Miller [this message]
2017-06-13 17:59 ` [RFC PATCH net-next 08/15] bpf: Add TCP connection BPF callbacks Lawrence Brakmo
2017-06-13 17:59 ` [RFC PATCH net-next 09/15] bpf: Sample BPF program to set buffer sizes Lawrence Brakmo
2017-06-13 21:17 ` David Miller
2017-06-13 17:59 ` [RFC PATCH net-next 10/15] bpf: Add support for changing congestion control Lawrence Brakmo
2017-06-13 21:17 ` David Miller
2017-06-13 18:00 ` [RFC PATCH net-next 11/15] bpf: Sample BPF program to set " Lawrence Brakmo
2017-06-13 21:31 ` David Miller
2017-06-13 18:00 ` [RFC PATCH net-next 12/15] bpf: Adds support for setting initial cwnd Lawrence Brakmo
2017-06-13 18:00 ` [RFC PATCH net-next 13/15] bpf: Sample BPF program to set " Lawrence Brakmo
2017-06-13 21:31 ` David Miller
2017-06-13 18:00 ` [RFC PATCH net-next 14/15] bpf: Adds support for setting sndcwnd clamp Lawrence Brakmo
2017-06-13 18:00 ` [RFC PATCH net-next 15/15] bpf: Sample bpf program to set " Lawrence Brakmo
2017-06-13 21:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170613.171641.971171683474923625.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ast@fb.com \
--cc=bmatheny@fb.com \
--cc=brakmo@fb.com \
--cc=daniel@iogearbox.net \
--cc=dsa@cumulusnetworks.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).