From: Andrew Lunn <andrew@lunn.ch>
To: Salil Mehta <salil.mehta@huawei.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"Zhuangyuzeng (Yisen)" <yisen.zhuang@huawei.com>,
huangdaode <huangdaode@hisilicon.com>,
"lipeng (Y)" <lipeng321@huawei.com>,
"mehta.salil.lnk@gmail.com" <mehta.salil.lnk@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linuxarm <linuxarm@huawei.com>
Subject: Re: [PATCH net-next 6/9] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC
Date: Tue, 13 Jun 2017 23:15:54 +0200 [thread overview]
Message-ID: <20170613211554.GD15847@lunn.ch> (raw)
In-Reply-To: <F4CC6FACFEB3C54C9141D49AD221F7F93B7A2303@FRAEML521-MBX.china.huawei.com>
> You are correct is_c45 should not be derived from the type of PHY like
> it is being done here. I have changed this code and now we are getting this
> information from the IMP(Integrated Management Processor) which handles
> the NIC commands and also maintains Ethernet specific configuration.
Florian
With c22, registering the MDIO bus is enough to cause all c22
addresses to be probed and the PHYs found. If you are not using device
tree, you can then use phy_find_first() to get the first phy on the
bus.
As far as i remember, this does not work for c45. mdiobus_scan() is
only looking for c22 PHYs. Maybe we should be making mdiobus_scan()
look first for a c45 and then try c22?
Andrew
next prev parent reply other threads:[~2017-06-13 21:15 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-10 3:46 [PATCH net-next 0/9] Hisilicon Network Subsystem 3 Ethernet Driver Salil Mehta
2017-06-10 3:46 ` [PATCH net-next 1/9] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC Salil Mehta
2017-06-10 12:43 ` Mintz, Yuval
2017-06-13 17:08 ` Salil Mehta
2017-06-14 8:04 ` Mintz, Yuval
2017-06-17 12:00 ` Salil Mehta
2017-06-10 3:46 ` [PATCH net-next 2/9] net: hns3: Add support of the HNAE3 framework Salil Mehta
2017-06-10 3:46 ` [PATCH net-next 3/9] net: hns3: Add HNS3 IMP(Integrated Mgmt Proc) Cmd Interface Support Salil Mehta
2017-06-10 3:46 ` [PATCH net-next 4/9] net: hns3: Add HNS3 Acceleration Engine & Compatibility Layer Support Salil Mehta
2017-06-10 3:46 ` [PATCH net-next 5/9] net: hns3: Add support of TX Scheduler & Shaper to HNS3 driver Salil Mehta
2017-06-10 3:46 ` [PATCH net-next 6/9] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC Salil Mehta
2017-06-10 19:04 ` Florian Fainelli
2017-06-11 2:43 ` Andrew Lunn
2017-06-13 20:47 ` Salil Mehta
2017-06-13 21:15 ` Andrew Lunn [this message]
2017-06-13 21:37 ` Salil Mehta
2017-06-13 22:40 ` Andrew Lunn
2017-06-13 23:01 ` Salil Mehta
2017-06-14 1:10 ` Andrew Lunn
2017-06-17 11:10 ` Salil Mehta
2017-06-10 3:46 ` [PATCH net-next 7/9] net: hns3: Add Ethtool support to HNS3 driver Salil Mehta
2017-06-10 3:46 ` [PATCH net-next 8/9] net: hns3: Add support of debugfs interface " Salil Mehta
2017-06-10 12:51 ` Mintz, Yuval
2017-06-10 16:35 ` Andrew Lunn
2017-06-13 17:16 ` Salil Mehta
2017-06-13 17:14 ` Salil Mehta
2017-06-10 3:46 ` [PATCH net-next 9/9] net: hns3: Add HNS3 driver to kernel build framework & MAINTAINERS Salil Mehta
2017-06-11 13:41 ` kbuild test robot
2017-06-11 13:41 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170613211554.GD15847@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=huangdaode@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lipeng321@huawei.com \
--cc=mehta.salil.lnk@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).