From: Stephen Hemminger <stephen@networkplumber.org>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 net-next] ip neigh: allow flush FAILED neighbour entry
Date: Wed, 14 Jun 2017 09:54:50 -0700 [thread overview]
Message-ID: <20170614095450.3c9b5dcb@xeon-e3> (raw)
In-Reply-To: <1496651489-28110-1-git-send-email-liuhangbin@gmail.com>
On Mon, 5 Jun 2017 16:31:29 +0800
Hangbin Liu <liuhangbin@gmail.com> wrote:
> After upstream commit 5071034e4af7 ('neigh: Really delete an arp/neigh entry
> on "ip neigh delete" or "arp -d"'), we could delete a single FAILED neighbour
> entry now. But `ip neigh flush` still skip the FAILED entry.
>
> Let's remove this filter so we can also flush FAILED entry.
>
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
This might create a problem. iproute2 has to be forward/backwards compatiable
with multiple kernel versions. Users must be able to run newer versions of ip
command on older kernels.
What happens if you run the ip command with your patch on older kernels?
next prev parent reply other threads:[~2017-06-14 16:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-05 8:31 [PATCH iproute2 net-next] ip neigh: allow flush FAILED neighbour entry Hangbin Liu
2017-06-14 16:54 ` Stephen Hemminger [this message]
2017-06-15 2:30 ` Hangbin Liu
2017-06-15 15:30 ` Stephen Hemminger
2017-06-16 3:31 ` [PATCHv2 " Hangbin Liu
2017-06-16 16:01 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170614095450.3c9b5dcb@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox