From: Stephen Hemminger <stephen@networkplumber.org>
To: Jakub Sitnicki <jkbs@redhat.com>
Cc: netdev@vger.kernel.org
Subject: Re: [iproute PATCH] iproute: Remove useless check for nexthop keyword when setting RTA_OIF
Date: Wed, 14 Jun 2017 09:57:09 -0700 [thread overview]
Message-ID: <20170614095709.46aac3e0@xeon-e3> (raw)
In-Reply-To: <20170607132313.5290-1-jkbs@redhat.com>
On Wed, 7 Jun 2017 15:23:13 +0200
Jakub Sitnicki <jkbs@redhat.com> wrote:
> When modifying a route we set the RTA_OIF attribute only if a device was
> specified with "dev" or "oif" keyword. But for some unknown reason we
> earlier alternatively check also for the presence of "nexthop" keyword,
> even though it has no effect. So remove the pointless check.
>
> Signed-off-by: Jakub Sitnicki <jkbs@redhat.com>
Makes sense, applied.
prev parent reply other threads:[~2017-06-14 16:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 13:23 [iproute PATCH] iproute: Remove useless check for nexthop keyword when setting RTA_OIF Jakub Sitnicki
2017-06-14 16:57 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170614095709.46aac3e0@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=jkbs@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).