From: Stephen Hemminger <stephen@networkplumber.org>
To: Krister Johansen <kjlx@templeofstupid.com>
Cc: netdev@vger.kernel.org, simon.horman@netronome.com, dsahern@gmail.com
Subject: Re: [PATCH iproute/master 2/3] iptunnel: add support for mpls/ip to sit tunnels
Date: Wed, 14 Jun 2017 10:02:11 -0700 [thread overview]
Message-ID: <20170614100211.1346dc4e@xeon-e3> (raw)
In-Reply-To: <1497058292-10099-3-git-send-email-kjlx@templeofstupid.com>
On Fri, 9 Jun 2017 18:31:31 -0700
Krister Johansen <kjlx@templeofstupid.com> wrote:
> diff --git a/include/utils.h b/include/utils.h
> index bfbc9e6..60ffde4 100644
> --- a/include/utils.h
> +++ b/include/utils.h
> @@ -87,6 +87,9 @@ struct ipx_addr {
> #ifndef AF_MPLS
> # define AF_MPLS 28
> #endif
> +#ifndef IPPROTO_MPLS
> +#define IPPROTO_MPLS 137
> +#endif
>
I am a little concerned that this definition may end up being different
between kernel and iproute2. It looks like utils.h already has lots of duplicate
definitions of things that are in standard include directory.
Most of these like IPSEC and DECNET are old, but MPLS might get changed
in the process of going into glibc.
Is there anyway to get this from the kernel headers which are cloned
into include/linux/ already?
next prev parent reply other threads:[~2017-06-14 17:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-10 1:31 [PATCH iproute/master 0/3] lost mpls ip tunnel patches Krister Johansen
2017-06-10 1:31 ` [PATCH iproute/master 1/3] iptunnel: document mode parameter for sit tunnels Krister Johansen
2017-06-10 1:31 ` [PATCH iproute/master 2/3] iptunnel: add support for mpls/ip to " Krister Johansen
2017-06-14 17:02 ` Stephen Hemminger [this message]
2017-06-14 17:11 ` Krister Johansen
2017-06-14 17:16 ` David Ahern
2017-06-15 18:31 ` Krister Johansen
2017-06-10 1:31 ` [PATCH iproute/master 3/3] iptunnel: add support for mpls/ip to ipip tunnels Krister Johansen
2017-06-14 17:24 ` [PATCH iproute/master 0/3] lost mpls ip tunnel patches Stephen Hemminger
2017-06-14 17:33 ` Krister Johansen
2017-07-05 16:06 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170614100211.1346dc4e@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dsahern@gmail.com \
--cc=kjlx@templeofstupid.com \
--cc=netdev@vger.kernel.org \
--cc=simon.horman@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).