netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Changhyeok Bae <changhyeok.bae@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [iproute2][PATCH] ip: Remove unneed header
Date: Wed, 14 Jun 2017 10:04:35 -0700	[thread overview]
Message-ID: <20170614100435.30df62d3@xeon-e3> (raw)
In-Reply-To: <1497242015-11611-1-git-send-email-changhyeok.bae@gmail.com>

On Mon, 12 Jun 2017 04:33:35 +0000
Changhyeok Bae <changhyeok.bae@gmail.com> wrote:

> Fix redefinition of struct ethhdr with a suitably patched musl libc
> that suppresses the kernel if_ether.h.
> 
> Signed-off-by: Changhyeok Bae <changhyeok.bae@gmail.com>
> ---
>  ip/iplink_bridge.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/ip/iplink_bridge.c b/ip/iplink_bridge.c
> index cccdec1..f065b22 100644
> --- a/ip/iplink_bridge.c
> +++ b/ip/iplink_bridge.c
> @@ -13,7 +13,6 @@
>  #include <stdlib.h>
>  #include <string.h>
>  #include <netinet/in.h>
> -#include <netinet/ether.h>
>  #include <linux/if_link.h>
>  #include <linux/if_bridge.h>
>  #include <net/if.h>

Sorry, doing this causes:

iplink_bridge.c: In function ‘br_dump_bridge_id’:
iplink_bridge.c:77:2: warning: implicit declaration of function ‘ether_ntoa_r’ [-Wimplicit-function-declaration]
  ether_ntoa_r((const struct ether_addr *)id->addr, eaddr);

      reply	other threads:[~2017-06-14 17:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-12  4:33 [iproute2][PATCH] ip: Remove unneed header Changhyeok Bae
2017-06-14 17:04 ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170614100435.30df62d3@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=changhyeok.bae@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).