* [PATCH net-next] net/mlxfw: fix a NULL dereference
@ 2017-06-14 10:41 Dan Carpenter
2017-06-14 11:03 ` Yotam Gigi
2017-06-14 19:33 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2017-06-14 10:41 UTC (permalink / raw)
To: Yotam Gigi; +Cc: netdev, kernel-janitors
If we hit this error path we end up returning ERR_PTR(0) which is NULL.
The caller is not expecting that so it results in a NULL dereference.
Fixes: 410ed13cae39 ("Add the mlxfw module for Mellanox firmware flash process")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c b/drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c
index 628150d28061..993cb5ba934e 100644
--- a/drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c
+++ b/drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c
@@ -594,6 +594,7 @@ struct mlxfw_mfa2_component *
if (memcmp(comp_data->buff, mlxfw_mfa2_comp_magic,
mlxfw_mfa2_comp_magic_len) != 0) {
pr_err("Component has wrong magic\n");
+ err = -EINVAL;
goto err_out;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net/mlxfw: fix a NULL dereference
2017-06-14 10:41 [PATCH net-next] net/mlxfw: fix a NULL dereference Dan Carpenter
@ 2017-06-14 11:03 ` Yotam Gigi
2017-06-14 19:33 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Yotam Gigi @ 2017-06-14 11:03 UTC (permalink / raw)
To: Dan Carpenter; +Cc: netdev, kernel-janitors
On 06/14/2017 01:41 PM, Dan Carpenter wrote:
> If we hit this error path we end up returning ERR_PTR(0) which is NULL.
> The caller is not expecting that so it results in a NULL dereference.
>
> Fixes: 410ed13cae39 ("Add the mlxfw module for Mellanox firmware flash process")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c b/drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c
> index 628150d28061..993cb5ba934e 100644
> --- a/drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c
> +++ b/drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c
> @@ -594,6 +594,7 @@ struct mlxfw_mfa2_component *
> if (memcmp(comp_data->buff, mlxfw_mfa2_comp_magic,
> mlxfw_mfa2_comp_magic_len) != 0) {
> pr_err("Component has wrong magic\n");
> + err = -EINVAL;
> goto err_out;
> }
>
Acked-by: Yotam Gigi <yotamg@mellanox.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net/mlxfw: fix a NULL dereference
2017-06-14 10:41 [PATCH net-next] net/mlxfw: fix a NULL dereference Dan Carpenter
2017-06-14 11:03 ` Yotam Gigi
@ 2017-06-14 19:33 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-06-14 19:33 UTC (permalink / raw)
To: dan.carpenter; +Cc: yotamg, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 14 Jun 2017 13:41:52 +0300
> If we hit this error path we end up returning ERR_PTR(0) which is NULL.
> The caller is not expecting that so it results in a NULL dereference.
>
> Fixes: 410ed13cae39 ("Add the mlxfw module for Mellanox firmware flash process")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-14 19:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-14 10:41 [PATCH net-next] net/mlxfw: fix a NULL dereference Dan Carpenter
2017-06-14 11:03 ` Yotam Gigi
2017-06-14 19:33 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox