From: Peter Dawson <petedaws@gmail.com>
To: 严海双 <yanhaishuang@cmss.chinamobile.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Patrick McHardy <kaber@trash.net>,
Daniel Borkmann <daniel@iogearbox.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ip6_tunnel: Correct tos value in collect_md mode
Date: Wed, 14 Jun 2017 15:28:39 +1000 [thread overview]
Message-ID: <20170614152839.38406ce2@gmail.com> (raw)
In-Reply-To: <9E61EADF-769B-431A-81EA-ADBAAD32ABD3@cmss.chinamobile.com>
On Wed, 14 Jun 2017 10:54:31 +0800
严海双 <yanhaishuang@cmss.chinamobile.com> wrote:
> > Changes since v2:
> > * mask key->tos with RT_TOS() suggested by Daniel
Can you help me understand the rationale for this change? Is there are bug introduced by dsfield = ip6_tclass(key->label); ?
The RT_TOS masks out 4bits of the 8bit tos field in accordance with RFC1349 (obsoleted by RFC2474). IPv6 does not have a TOS field. So it dosen't make sense to apply a TOS value to the outer header of an IPv6 tunnel.
next prev parent reply other threads:[~2017-06-14 5:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 2:48 [PATCH] ip6_tunnel: Correct tos value in collect_md mode Haishuang Yan
2017-06-14 2:54 ` 严海双
2017-06-14 5:28 ` Peter Dawson [this message]
2017-06-15 0:58 ` 严海双
-- strict thread matches above, loose matches on Subject: below --
2017-06-13 7:55 Haishuang Yan
2017-06-13 9:57 ` Daniel Borkmann
[not found] ` <0D379591-C5AA-496C-BC00-18005EAA7D21@cmss.chinamobile.com>
2017-06-13 15:37 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170614152839.38406ce2@gmail.com \
--to=petedaws@gmail.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yanhaishuang@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).