From: Krister Johansen <kjlx@templeofstupid.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Krister Johansen <kjlx@templeofstupid.com>,
netdev@vger.kernel.org, simon.horman@netronome.com,
dsahern@gmail.com
Subject: Re: [PATCH iproute/master 0/3] lost mpls ip tunnel patches
Date: Wed, 14 Jun 2017 10:33:22 -0700 [thread overview]
Message-ID: <20170614173322.GC2368@templeofstupid.com> (raw)
In-Reply-To: <20170614102451.42b301bd@xeon-e3>
On Wed, Jun 14, 2017 at 10:24:51AM -0700, Stephen Hemminger wrote:
> On Fri, 9 Jun 2017 18:31:29 -0700
> Krister Johansen <kjlx@templeofstupid.com> wrote:
>
> > Hi Stephen,
> > I'm a bit unsure of the decorum in this particular situation. Kernel
> > support for mpls/ip tunnels was integrated back in July of 2016. At the
> > time, the author of that feature sent out a RFC patch for the iproute
> > support but never followed up on subsequent code review comments.
> >
> > The kernel support got merged, but the iproute support never made it in.
> > I wanted to run some tests with these features. In the process, I
> > tracked down the author's original patches, merged them into current
> > iproute, and attempted to address the comments from code reviewers.
> >
>
> In order to get merged, an RFC message should be followed by a final
> non RFC version. I think you will find the original's were marked
> in patchwork as RFC.
Yes, absolutely true. I was just unsure of the protocol for getting
these merged when I'm not the original author. Trying to ensure that
credit is given where it is due, and I'm following the appropriate
procedures.
Thanks,
-K
next prev parent reply other threads:[~2017-06-14 17:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-10 1:31 [PATCH iproute/master 0/3] lost mpls ip tunnel patches Krister Johansen
2017-06-10 1:31 ` [PATCH iproute/master 1/3] iptunnel: document mode parameter for sit tunnels Krister Johansen
2017-06-10 1:31 ` [PATCH iproute/master 2/3] iptunnel: add support for mpls/ip to " Krister Johansen
2017-06-14 17:02 ` Stephen Hemminger
2017-06-14 17:11 ` Krister Johansen
2017-06-14 17:16 ` David Ahern
2017-06-15 18:31 ` Krister Johansen
2017-06-10 1:31 ` [PATCH iproute/master 3/3] iptunnel: add support for mpls/ip to ipip tunnels Krister Johansen
2017-06-14 17:24 ` [PATCH iproute/master 0/3] lost mpls ip tunnel patches Stephen Hemminger
2017-06-14 17:33 ` Krister Johansen [this message]
2017-07-05 16:06 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170614173322.GC2368@templeofstupid.com \
--to=kjlx@templeofstupid.com \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=simon.horman@netronome.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).