From: David Miller <davem@davemloft.net>
To: dhowells@redhat.com
Cc: netdev@vger.kernel.org, linux-afs@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] rxrpc: Fix several cases where a padded len isn't checked in ticket decode
Date: Thu, 15 Jun 2017 14:27:34 -0400 (EDT) [thread overview]
Message-ID: <20170615.142734.1952678170179907268.davem@davemloft.net> (raw)
In-Reply-To: <149748194451.23919.13232256832988154536.stgit@warthog.procyon.org.uk>
From: David Howells <dhowells@redhat.com>
Date: Thu, 15 Jun 2017 00:12:24 +0100
> This fixes CVE-2017-7482.
>
> When a kerberos 5 ticket is being decoded so that it can be loaded into an
> rxrpc-type key, there are several places in which the length of a
> variable-length field is checked to make sure that it's not going to
> overrun the available data - but the data is padded to the nearest
> four-byte boundary and the code doesn't check for this extra. This could
> lead to the size-remaining variable wrapping and the data pointer going
> over the end of the buffer.
>
> Fix this by making the various variable-length data checks use the padded
> length.
>
> Reported-by: 石磊 <shilei-c@360.cn>
> Signed-off-by: David Howells <dhowells@redhat.com>
> Reviewed-by: Marc Dionne <marc.c.dionne@auristor.com>
> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks David.
prev parent reply other threads:[~2017-06-15 18:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 23:12 [PATCH net] rxrpc: Fix several cases where a padded len isn't checked in ticket decode David Howells
2017-06-15 18:27 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170615.142734.1952678170179907268.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).