From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
<netdev@vger.kernel.org>, <intel-wired-lan@lists.osuosl.org>,
<linux-kernel@vger.kernel.org>,
jesse.brandeburg@intel.com
Subject: Re: [Intel-wired-lan] [PATCH] intel: i40e: virtchnl: fix incorrect variable assignment
Date: Thu, 15 Jun 2017 13:50:33 -0700 [thread overview]
Message-ID: <20170615135033.00001ecf@intel.com> (raw)
In-Reply-To: <20170615023826.GA8136@embeddedgus>
On Wed, 14 Jun 2017 21:38:26 -0500
"Gustavo A. R. Silva" <garsilva@embeddedor.com> wrote:
> Fix incorrect variable assignment.
> Based on line 1511: aq_ret = I40_ERR_PARAM; the correct variable to be
> used in this instance is aq_ret instead of ret. Also, variable ret is
> updated at line 1602 just before return, so assigning a value to this
> variable in this code block is useless.
>
> Addresses-Coverity-ID: 1397693
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Thanks for the fix, looks reasonable.
Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
next prev parent reply other threads:[~2017-06-15 20:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-15 2:38 [PATCH] intel: i40e: virtchnl: fix incorrect variable assignment Gustavo A. R. Silva
2017-06-15 20:50 ` Jesse Brandeburg [this message]
2017-06-15 21:07 ` [Intel-wired-lan] " Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170615135033.00001ecf@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=garsilva@embeddedor.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).