From: David Miller <davem@davemloft.net>
To: fengguang.wu@intel.com
Cc: davejwatson@fb.com, kbuild-all@01.org, netdev@vger.kernel.org,
borisp@mellanox.com, ilyal@mellanox.com, aviadye@mellanox.com
Subject: Re: [net-next:master 1119/1146] ERROR: "tcp_rate_check_app_limited" [net/tls/tls.ko] undefined!
Date: Fri, 16 Jun 2017 11:29:32 -0400 (EDT) [thread overview]
Message-ID: <20170616.112932.1450887873847611693.davem@davemloft.net> (raw)
In-Reply-To: <201706160508.cYd5HQKm%fengguang.wu@intel.com>
From: kbuild test robot <fengguang.wu@intel.com>
Date: Fri, 16 Jun 2017 05:19:10 +0800
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
> head: 3715c47bcda8bb56f7e2be27276282a2d0d48c09
> commit: 3c4d7559159bfe1e3b94df3a657b2cda3a34e218 [1119/1146] tls: kernel TLS support
> config: x86_64-randconfig-u0-06160346 (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
> git checkout 3c4d7559159bfe1e3b94df3a657b2cda3a34e218
> # save the attached .config to linux build tree
> make ARCH=x86_64
>
> All errors (new ones prefixed by >>):
>
> ERROR: "tcp_prot" [net/tls/tls.ko] undefined!
>>> ERROR: "tcp_rate_check_app_limited" [net/tls/tls.ko] undefined!
> ERROR: "tcp_register_ulp" [net/tls/tls.ko] undefined!
> ERROR: "tcp_unregister_ulp" [net/tls/tls.ko] undefined!
> ERROR: "do_tcp_sendpages" [net/tls/tls.ko] undefined!
I've applied the following to fix this.
David et al, you must be more responsive when you add build regressions
to the tree like this.
Thank you.
====================
>From 54144b4825ea7790cbc32a0f75a1103a97907646 Mon Sep 17 00:00:00 2001
From: "David S. Miller" <davem@davemloft.net>
Date: Fri, 16 Jun 2017 11:28:49 -0400
Subject: [PATCH] tls: Depend upon INET not plain NET.
We refer to TCP et al. symbols so have to use INET as
the dependency.
ERROR: "tcp_prot" [net/tls/tls.ko] undefined!
>> ERROR: "tcp_rate_check_app_limited" [net/tls/tls.ko] undefined!
ERROR: "tcp_register_ulp" [net/tls/tls.ko] undefined!
ERROR: "tcp_unregister_ulp" [net/tls/tls.ko] undefined!
ERROR: "do_tcp_sendpages" [net/tls/tls.ko] undefined!
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---
net/tls/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/tls/Kconfig b/net/tls/Kconfig
index 61e5329..b13541f 100644
--- a/net/tls/Kconfig
+++ b/net/tls/Kconfig
@@ -3,7 +3,7 @@
#
config TLS
tristate "Transport Layer Security support"
- depends on NET
+ depends on INET
default m
---help---
Enable kernel support for TLS protocol. This allows symmetric
--
2.4.11
prev parent reply other threads:[~2017-06-16 15:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-15 21:19 [net-next:master 1119/1146] ERROR: "tcp_rate_check_app_limited" [net/tls/tls.ko] undefined! kbuild test robot
2017-06-16 15:29 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170616.112932.1450887873847611693.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aviadye@mellanox.com \
--cc=borisp@mellanox.com \
--cc=davejwatson@fb.com \
--cc=fengguang.wu@intel.com \
--cc=ilyal@mellanox.com \
--cc=kbuild-all@01.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).