From: David Miller <davem@davemloft.net>
To: jwi@linux.vnet.ibm.com
Cc: netdev@vger.kernel.org, linux-s390@vger.kernel.org,
schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
raspl@linux.vnet.ibm.com, ubraun@linux.vnet.ibm.com
Subject: Re: [PATCH net-next 4/4] s390/qeth: use diag26c to get MAC address on L2
Date: Mon, 19 Jun 2017 10:48:23 -0400 (EDT) [thread overview]
Message-ID: <20170619.104823.817601669822671550.davem@davemloft.net> (raw)
In-Reply-To: <20170619112225.30471-5-jwi@linux.vnet.ibm.com>
From: Julian Wiedmann <jwi@linux.vnet.ibm.com>
Date: Mon, 19 Jun 2017 13:22:25 +0200
> +{
> + struct diag26c_mac_req *request;
> + struct diag26c_mac_resp *response;
> + struct ccw_dev_id id;
> + int rc;
> +
Please order local variable declarations from longest to shortest
line (reverse christmas tree).
> + if ((request->resp_buf_len < sizeof(*response)) ||
> + (response->version != request->resp_version)) {
Excessive parenthesis here.
Thanks.
next prev parent reply other threads:[~2017-06-19 14:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-19 11:22 [PATCH net-next 0/4] s390/net updates, part 2 Julian Wiedmann
2017-06-19 11:22 ` [PATCH net-next 1/4] s390/qeth: add ipa return codes for bridgeport Julian Wiedmann
2017-06-19 11:22 ` [PATCH net-next 2/4] s390/qeth: fix packing buffer statistics Julian Wiedmann
2017-06-19 11:22 ` [PATCH net-next 3/4] s390/diag: add diag26c support Julian Wiedmann
2017-06-19 14:47 ` David Miller
2017-06-19 15:34 ` Martin Schwidefsky
2017-06-19 17:37 ` David Miller
2017-06-21 15:30 ` Martin Schwidefsky
2017-06-19 11:22 ` [PATCH net-next 4/4] s390/qeth: use diag26c to get MAC address on L2 Julian Wiedmann
2017-06-19 14:48 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-06-20 14:00 [PATCH net-next 0/4] s390/net updates, part 2 (v2) Julian Wiedmann
2017-06-20 14:00 ` [PATCH net-next 4/4] s390/qeth: use diag26c to get MAC address on L2 Julian Wiedmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170619.104823.817601669822671550.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=heiko.carstens@de.ibm.com \
--cc=jwi@linux.vnet.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=raspl@linux.vnet.ibm.com \
--cc=schwidefsky@de.ibm.com \
--cc=ubraun@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).