From: David Miller <davem@davemloft.net>
To: gfree.wind@vip.163.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] net: 8021q: Fix one possible panic caused by BUG_ON in free_netdev
Date: Mon, 19 Jun 2017 14:10:36 -0400 (EDT) [thread overview]
Message-ID: <20170619.141036.665343734571702647.davem@davemloft.net> (raw)
In-Reply-To: <1497596402-81457-1-git-send-email-gfree.wind@vip.163.com>
From: gfree.wind@vip.163.com
Date: Fri, 16 Jun 2017 15:00:02 +0800
> From: Gao Feng <gfree.wind@vip.163.com>
>
> The register_vlan_device would invoke free_netdev directly, when
> register_vlan_dev failed. It would trigger the BUG_ON in free_netdev
> if the dev was already registered. In this case, the netdev would be
> freed in netdev_run_todo later.
>
> So add one condition check now. Only when dev is not registered, then
> free it directly.
>
> The following is the part coredump when netdev_upper_dev_link failed
> in register_vlan_dev. I removed the lines which are too long.
...
> Signed-off-by: Gao Feng <gfree.wind@vip.163.com>
Ok, I guess this is how we will have to fix this.
Applied, thanks.
prev parent reply other threads:[~2017-06-19 18:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-16 7:00 [PATCH net] net: 8021q: Fix one possible panic caused by BUG_ON in free_netdev gfree.wind
2017-06-19 18:10 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170619.141036.665343734571702647.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gfree.wind@vip.163.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).