From: Stephen Hemminger <stephen@networkplumber.org>
To: David Miller <davem@davemloft.net>
Cc: xiyou.wangcong@gmail.com, lucasb@mojatatu.com,
netdev@vger.kernel.org, jiri@resnulli.us, mrv@mojatatu.com,
jhs@mojatatu.com
Subject: Re: [PATCH net-next 0/1] Introduction of the tc tests
Date: Mon, 19 Jun 2017 22:40:27 -0700 [thread overview]
Message-ID: <20170619224027.133c3578@plumbers-lap.home.lan> (raw)
In-Reply-To: <20170619.234819.333574326143678552.davem@davemloft.net>
On Mon, 19 Jun 2017 23:48:19 -0400 (EDT)
David Miller <davem@davemloft.net> wrote:
> From: Cong Wang <xiyou.wangcong@gmail.com>
> Date: Mon, 19 Jun 2017 16:37:29 -0700
>
> > Hi,
> >
> > On Fri, Jun 16, 2017 at 2:22 PM, Lucas Bates <lucasb@mojatatu.com> wrote:
> >> Apologies for sending this as one big patch. I've been sitting on this a little
> >> too long, but it's ready and I wanted to get it out.
> >>
> >> There are a limited number of tests to start - I plan to add more on a regular
> >> basis.
> >>
> >> Lucas Bates (1):
> >> selftests: Introduce tc testsuite
> >
> > Nice work!
> >
> > Is there any particular reason you want to put these tests in kernel tree
> > especially tools/testing/selftests/ ?
>
> Yeah, it would be absolutely terrible if we had more tests in the
> kernel selftests area for networking.
>
> More seriously, we need more, not less, tests in the kernel networking
> selftests directory.
>
> It doesn't belong in iproute2 because we want a place to put things
> that automatically get tested when someone makes kernel changes and
> can be integrated into the kernel development workflow.
>
> I want as many tests as possible under there, so I'm really surprised
> that you're asking "why" tests are being added there.
The "Occum's razor" for deciding where tests belong should be does
the test need to change to respond to kernel change? Don't want to have
iproute2 tests that have if (kernel_version > ...)
next prev parent reply other threads:[~2017-06-20 5:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-16 21:22 [PATCH net-next 0/1] Introduction of the tc tests Lucas Bates
2017-06-16 21:22 ` [PATCH net-next 1/1] selftests: Introduce tc testsuite Lucas Bates
2017-06-19 23:37 ` [PATCH net-next 0/1] Introduction of the tc tests Cong Wang
2017-06-20 3:48 ` David Miller
2017-06-20 4:13 ` Cong Wang
2017-06-20 15:36 ` David Miller
2017-06-20 5:38 ` Stephen Hemminger
2017-06-20 5:40 ` Stephen Hemminger [this message]
2017-06-20 11:13 ` Jamal Hadi Salim
2017-06-20 17:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170619224027.133c3578@plumbers-lap.home.lan \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=lucasb@mojatatu.com \
--cc=mrv@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).