From: David Miller <davem@davemloft.net>
To: dvlasenk@redhat.com
Cc: netdev@vger.kernel.org, felix.manlunas@cavium.com,
prasad.kanneganti@cavium.com, derek.chickles@cavium.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] liquidio: stop using huge static buffer, save 4096k in .data
Date: Tue, 20 Jun 2017 15:21:42 -0400 (EDT) [thread overview]
Message-ID: <20170620.152142.1443468587541525646.davem@davemloft.net> (raw)
In-Reply-To: <20170619195052.13176-1-dvlasenk@redhat.com>
From: Denys Vlasenko <dvlasenk@redhat.com>
Date: Mon, 19 Jun 2017 21:50:52 +0200
> Only compile-tested - I don't have the hardware.
>
> From code inspection, octeon_pci_write_core_mem() appears to be safe wrt
> unaligned source. In any case, u8 fbuf[] was not guaranteed to be aligned
> anyway.
>
> Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
Looks good to me but I'll let one of the liquidio guys review this first
before I apply it.
next prev parent reply other threads:[~2017-06-20 19:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-19 19:50 [PATCH] liquidio: stop using huge static buffer, save 4096k in .data Denys Vlasenko
2017-06-20 19:21 ` David Miller [this message]
2017-06-20 20:15 ` Chickles, Derek
2017-06-20 20:51 ` Felix Manlunas
2017-06-21 1:17 ` David Miller
2017-06-21 2:59 ` Felix Manlunas
2017-06-22 15:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170620.152142.1443468587541525646.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=derek.chickles@cavium.com \
--cc=dvlasenk@redhat.com \
--cc=felix.manlunas@cavium.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=prasad.kanneganti@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).