From: David Miller <davem@davemloft.net>
To: gvaradar@cisco.com
Cc: netdev@vger.kernel.org, benve@cisco.com
Subject: Re: [PATCH net-next v2] enic: Fix format truncation warning
Date: Tue, 20 Jun 2017 15:27:14 -0400 (EDT) [thread overview]
Message-ID: <20170620.152714.351257547066260274.davem@davemloft.net> (raw)
In-Reply-To: <20170619232844.34916-1-gvaradar@cisco.com>
From: Govindarajulu Varadarajan <gvaradar@cisco.com>
Date: Mon, 19 Jun 2017 16:28:44 -0700
> With -Wformat-truncation, gcc throws the following warning.
>
> Fix this by increasing the size of devname to accommodate 15 character
> netdev interface name and description.
>
> Remove length format precision for %s. We can fit entire name.
>
> Also increment the version.
>
> drivers/net/ethernet/cisco/enic/enic_main.c: In function ‘enic_open’:
> drivers/net/ethernet/cisco/enic/enic_main.c:1740:15: warning: ‘%u’ directive output may be truncated writing between 1 and 2 bytes into a region of size between 1 and 12 [-Wformat-truncation=]
> "%.11s-rx-%u", netdev->name, i);
> ^~
> drivers/net/ethernet/cisco/enic/enic_main.c:1740:5: note: directive argument in the range [0, 16]
> "%.11s-rx-%u", netdev->name, i);
> ^~~~~~~~~~~~~
> drivers/net/ethernet/cisco/enic/enic_main.c:1738:4: note: ‘snprintf’ output between 6 and 18 bytes into a destination of size 16
> snprintf(enic->msix[intr].devname,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> sizeof(enic->msix[intr].devname),
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> "%.11s-rx-%u", netdev->name, i);
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Govindarajulu Varadarajan <gvaradar@cisco.com>
> ---
> v2: dont use kasprintf, increase the devname size
> http://patchwork.ozlabs.org/patch/777568/
Applied, thank you.
prev parent reply other threads:[~2017-06-20 19:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-19 23:28 [PATCH net-next v2] enic: Fix format truncation warning Govindarajulu Varadarajan
2017-06-20 19:27 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170620.152714.351257547066260274.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=benve@cisco.com \
--cc=gvaradar@cisco.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).