From: David Miller <davem@davemloft.net>
To: ecree@solarflare.com
Cc: linux-net-drivers@solarflare.com, netdev@vger.kernel.org
Subject: Re: [PATCH net] sfc: remove duplicate up_write on VF filter_sem
Date: Tue, 20 Jun 2017 15:40:21 -0400 (EDT) [thread overview]
Message-ID: <20170620.154021.1071172261400917698.davem@davemloft.net> (raw)
In-Reply-To: <b718af2e-5737-3d98-0f45-cfbb25d43349@solarflare.com>
From: Edward Cree <ecree@solarflare.com>
Date: Tue, 20 Jun 2017 13:08:51 +0100
> Somehow two copies of the line 'up_write(&vf->efx->filter_sem);' got into
> efx_ef10_sriov_set_vf_vlan(). This would put the mutex in a bad state and
> cause all subsequent down attempts to hang.
>
> Fixes: 671b53eec2ed ("sfc: Ensure down_write(&filter_sem) and up_write() are matched before calling efx_net_open()")
> Signed-off-by: Edward Cree <ecree@solarflare.com>
Applied and queued up for -stable.
prev parent reply other threads:[~2017-06-20 19:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 12:08 [PATCH net] sfc: remove duplicate up_write on VF filter_sem Edward Cree
2017-06-20 19:40 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170620.154021.1071172261400917698.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).