From: David Miller <davem@davemloft.net>
To: felix.manlunas@cavium.com
Cc: Derek.Chickles@cavium.com, dvlasenk@redhat.com,
netdev@vger.kernel.org, Prasad.Kanneganti@cavium.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] liquidio: stop using huge static buffer, save 4096k in .data
Date: Tue, 20 Jun 2017 21:17:13 -0400 (EDT) [thread overview]
Message-ID: <20170620.211713.1253498659679389459.davem@davemloft.net> (raw)
In-Reply-To: <20170620205125.GA1364@felix-thinkpad.cavium.com>
From: Felix Manlunas <felix.manlunas@cavium.com>
Date: Tue, 20 Jun 2017 13:51:25 -0700
> From: Derek Chickles <Derek.Chickles@cavium.com>
> Date: Tue, 20 Jun 2017 13:15:34 -0700
>
>> > From: David Miller [mailto:davem@davemloft.net]
>> > Sent: Tuesday, June 20, 2017 12:22 PM
>> >
>> > From: Denys Vlasenko <dvlasenk@redhat.com>
>> > Date: Mon, 19 Jun 2017 21:50:52 +0200
>> >
>> > > Only compile-tested - I don't have the hardware.
>> > >
>> > > From code inspection, octeon_pci_write_core_mem() appears to be safe wrt
>> > > unaligned source. In any case, u8 fbuf[] was not guaranteed to be aligned
>> > > anyway.
>> > >
>> > > Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
>> >
>> > Looks good to me but I'll let one of the liquidio guys review this first
>> > before I apply it.
>>
>> Felix is going to try this out this week to confirm. Let's wait for his ack.
>
> This patch works. I tested it with a LiquidIO II adapter.
>
> ACK
Please ACK patches in the standard way which is in the form of:
Acked-by: David S. Miller <davem@davemloft.net>
This tag is recognized by tools and in particular the patchwork
site where networking patches are maintained, automatically
including your ACK into the patch I apply.
next prev parent reply other threads:[~2017-06-21 1:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-19 19:50 [PATCH] liquidio: stop using huge static buffer, save 4096k in .data Denys Vlasenko
2017-06-20 19:21 ` David Miller
2017-06-20 20:15 ` Chickles, Derek
2017-06-20 20:51 ` Felix Manlunas
2017-06-21 1:17 ` David Miller [this message]
2017-06-21 2:59 ` Felix Manlunas
2017-06-22 15:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170620.211713.1253498659679389459.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Derek.Chickles@cavium.com \
--cc=Prasad.Kanneganti@cavium.com \
--cc=dvlasenk@redhat.com \
--cc=felix.manlunas@cavium.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).