From: David Miller <davem@davemloft.net>
To: nfont@linux.vnet.ibm.com
Cc: netdev@vger.kernel.org, jallen@linux.vnet.ibm.com,
tlfalcon@linux.vnet.ibm.com
Subject: Re: [PATCH net-next] ibmvnic: Correct return code checking for ibmvnic_init during probe
Date: Wed, 21 Jun 2017 15:52:31 -0400 (EDT) [thread overview]
Message-ID: <20170621.155231.2270998903029219794.davem@davemloft.net> (raw)
In-Reply-To: <199365a2-50ce-1d16-8192-0eb4157c215f@linux.vnet.ibm.com>
From: Nathan Fontenot <nfont@linux.vnet.ibm.com>
Date: Wed, 21 Jun 2017 14:48:06 -0500
> On 06/21/2017 02:39 PM, David Miller wrote:
>> From: Nathan Fontenot <nfont@linux.vnet.ibm.com>
>> Date: Tue, 20 Jun 2017 17:21:54 -0400
>>
>>> Fixes: 6a2fb0e99f9c (ibmvnic: driver initialization for kdump/kexec)
>>
>> I'm incredibly curious where you got the idea to put the Fixes: tag
>> at the beginning of the commit message.
>
> I have no excuse. As you mentioned I should have looked at what others
> had done when using the Fixes.
>
> Would you like me to re-send with the Fixes tag corrected?
Yes, please.
prev parent reply other threads:[~2017-06-21 19:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 21:21 [PATCH net-next] ibmvnic: Correct return code checking for ibmvnic_init during probe Nathan Fontenot
2017-06-21 19:39 ` David Miller
2017-06-21 19:48 ` Nathan Fontenot
2017-06-21 19:52 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170621.155231.2270998903029219794.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jallen@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nfont@linux.vnet.ibm.com \
--cc=tlfalcon@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).