From: David Miller <davem@davemloft.net>
To: shannon.nelson@oracle.com
Cc: netdev@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] ldmvsw: add vio version and remote-mac to ethtool info
Date: Wed, 21 Jun 2017 17:27:40 -0400 (EDT) [thread overview]
Message-ID: <20170621.172740.195647522322509090.davem@davemloft.net> (raw)
In-Reply-To: <732eb629-450f-bfae-4535-0c6e5b2ccbe0@oracle.com>
From: Shannon Nelson <shannon.nelson@oracle.com>
Date: Wed, 21 Jun 2017 13:59:35 -0700
> On 6/21/2017 12:05 PM, David Miller wrote:
>> Also, this is not at all an appropriate place to expose this. The
>> "driver info" ethtool command is not a place to post per-connection
>> or per-link information.
>
> I knew it was a bit of a stretch, but almost made sense. However, I'd
> still like to put the vio version here - is that acceptable?
That part is fine.
>> Probably one of the IFLA_* netlink attributes would work best for
>> this. You could even use PHYS_PORT_ID for this, which gives you
>> 32 bytes to work with.
>
> Hmmm - good thought. I'll go poke at this and see what I can come up
> with. I gather from this that you agree that /sys is not the right
> place for this information, either.
Netlink is definitely preferred.
next prev parent reply other threads:[~2017-06-21 21:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 16:09 [PATCH net-next 0/2] sunvnet: add to ethtool data Shannon Nelson
2017-06-21 16:09 ` [PATCH net-next 1/2] ldmvsw: add vio version and remote-mac to ethtool info Shannon Nelson
2017-06-21 19:05 ` David Miller
2017-06-21 20:59 ` Shannon Nelson
2017-06-21 21:27 ` David Miller [this message]
2017-06-21 16:09 ` [PATCH net-next 2/2] sunvnet: implement basic ethtool get_settings Shannon Nelson
2017-06-21 19:06 ` David Miller
2017-06-21 20:59 ` Shannon Nelson
2017-06-21 21:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170621.172740.195647522322509090.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shannon.nelson@oracle.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).