From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felix Manlunas Subject: Re: [PATCH] liquidio: stop using huge static buffer, save 4096k in .data Date: Tue, 20 Jun 2017 19:59:03 -0700 Message-ID: <20170621025903.GA1261@felix-thinkpad.cavium.com> References: <20170620.152142.1443468587541525646.davem@davemloft.net> <20170620205125.GA1364@felix-thinkpad.cavium.com> <20170620.211713.1253498659679389459.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Derek.Chickles@cavium.com, dvlasenk@redhat.com, netdev@vger.kernel.org, Prasad.Kanneganti@cavium.com, linux-kernel@vger.kernel.org To: David Miller Return-path: Content-Disposition: inline In-Reply-To: <20170620.211713.1253498659679389459.davem@davemloft.net> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: David Miller Date: Tue, 20 Jun 2017 21:17:13 -0400 > From: Felix Manlunas > Date: Tue, 20 Jun 2017 13:51:25 -0700 > > > From: Derek Chickles > > Date: Tue, 20 Jun 2017 13:15:34 -0700 > > > >> > From: David Miller [mailto:davem@davemloft.net] > >> > Sent: Tuesday, June 20, 2017 12:22 PM > >> > > >> > From: Denys Vlasenko > >> > Date: Mon, 19 Jun 2017 21:50:52 +0200 > >> > > >> > > Only compile-tested - I don't have the hardware. > >> > > > >> > > From code inspection, octeon_pci_write_core_mem() appears to be safe wrt > >> > > unaligned source. In any case, u8 fbuf[] was not guaranteed to be aligned > >> > > anyway. > >> > > > >> > > Signed-off-by: Denys Vlasenko > >> > > >> > Looks good to me but I'll let one of the liquidio guys review this first > >> > before I apply it. > >> > >> Felix is going to try this out this week to confirm. Let's wait for his ack. > > > > This patch works. I tested it with a LiquidIO II adapter. > > > > ACK > > Please ACK patches in the standard way which is in the form of: > > Acked-by: David S. Miller > > This tag is recognized by tools and in particular the patchwork > site where networking patches are maintained, automatically > including your ACK into the patch I apply. Acked-by: Felix Manlunas