From: Andrew Lunn <andrew@lunn.ch>
To: Gal Pressman <galp@mellanox.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
"John W. Linville" <linville@tuxdriver.com>,
Saeed Mahameed <saeedm@mellanox.com>,
Vidya Sagar Ravipati <vidya@cumulusnetworks.com>,
Jiri Pirko <jiri@mellanox.com>,
David Decotigny <decot@googlers.com>,
kernel-team@fb.com
Subject: Re: [RFC PATCH net-next 3/3] net/mlx5e: Expose link down reason to ethtool
Date: Wed, 21 Jun 2017 16:03:18 +0200 [thread overview]
Message-ID: <20170621140318.GD27585@lunn.ch> (raw)
In-Reply-To: <1498050286-17141-4-git-send-email-galp@mellanox.com>
> +static int mlx5e_get_link_down_reason(struct net_device *netdev,
> + struct ethtool_link_down_reason *ldr)
> +{
> + struct mlx5e_priv *priv = netdev_priv(netdev);
> + u16 monitor_opcode;
> + int err;
> +
> + if (!netif_running(netdev)) {
> + ldr->reason = ETHTOOL_LINK_NETDEV_CARRIER_DOWN;
> + return 0;
> + }
This is generic, will work for any interface. The same is true for
ADMIN_DOWN. Either it is not required at all, since the information is
available via other means, or it should be in the core.
Andrew
next prev parent reply other threads:[~2017-06-21 14:03 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 13:04 [RFC PATCH net-next 0/3] ethtool: Add link down reason reporting Gal Pressman
2017-06-21 13:04 ` [RFC PATCH net-next 1/3] ethtool: Add link down reason callback Gal Pressman
2017-06-21 13:58 ` Andrew Lunn
2017-06-22 8:09 ` Gal Pressman
2017-06-22 13:34 ` Andrew Lunn
2017-06-23 8:23 ` Gal Pressman
2017-06-23 13:52 ` Andrew Lunn
2017-06-24 19:04 ` Andrew Lunn
2017-06-25 11:59 ` Gal Pressman
2017-06-25 15:19 ` Andrew Lunn
2017-06-26 11:52 ` Gal Pressman
2017-06-26 13:34 ` Andrew Lunn
2017-06-27 19:40 ` David Miller
2017-06-21 15:43 ` Stephen Hemminger
2017-06-22 10:33 ` Gal Pressman
2017-06-26 13:28 ` Andrew Lunn
2017-06-26 15:48 ` Gal Pressman
2017-06-21 13:04 ` [RFC PATCH net-next 2/3] net/mlx5: Add PDDR register infrastructure Gal Pressman
2017-06-21 13:04 ` [RFC PATCH net-next 3/3] net/mlx5e: Expose link down reason to ethtool Gal Pressman
2017-06-21 14:03 ` Andrew Lunn [this message]
2017-06-22 8:17 ` Gal Pressman
2017-06-22 4:33 ` Jakub Kicinski
2017-06-22 8:33 ` Gal Pressman
2017-06-22 22:38 ` Jakub Kicinski
2017-06-23 8:52 ` Gal Pressman
2017-06-21 15:44 ` [RFC PATCH net-next 0/3] ethtool: Add link down reason reporting Stephen Hemminger
2017-06-22 11:13 ` Gal Pressman
2017-06-22 4:14 ` Jakub Kicinski
2017-06-22 11:37 ` Gal Pressman
2017-06-22 21:53 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170621140318.GD27585@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=decot@googlers.com \
--cc=galp@mellanox.com \
--cc=jiri@mellanox.com \
--cc=kernel-team@fb.com \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=vidya@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).