From: Kalle Valo <kvalo@codeaurora.org>
To: Caesar Wang <wxt@rock-chips.com>
Cc: yangzy@marvell.com, jeffy.chen@rock-chips.com,
briannorris@chromium.org, linux-kernel@vger.kernel.org,
Caesar Wang <wxt@rock-chips.com>, Xinming Hu <huxm@marvell.com>,
Ganapathi Bhat <gbhat@marvell.com>,
Amitkumar Karwar <amitkarwar@gmail.com>,
linux-wireless@vger.kernel.org,
Nishant Sarmukadam <nishants@marvell.com>,
netdev@vger.kernel.org
Subject: Re: [v2] mwifiex: fixes the unexpected be printed log by default
Date: Wed, 21 Jun 2017 15:25:20 +0000 (UTC) [thread overview]
Message-ID: <20170621152520.5B96060250@smtp.codeaurora.org> (raw)
In-Reply-To: <1497438416-24665-1-git-send-email-wxt@rock-chips.com>
Caesar Wang <wxt@rock-chips.com> wrote:
> This patch uses WARN level is not printed by default.
>
> In some cases, some boards have always met the unused log be printed as
> follows.
> ...
> [23193.523182] mwifiex_pcie 0000:01:00.0: mwifiex_get_cfp:
> cannot find cfp by band 2 & channel=13 freq=0
> [23378.633684] mwifiex_pcie 0000:01:00.0: mwifiex_get_cfp:
> cannot find cfp by band 2 & channel=13 freq=0
>
> Due to we used the wifi default area was US and didn't support 12~14
> channels. As Frequencies:
> * 2412 MHz [1] (30.0 dBm)
> * 2417 MHz [2] (30.0 dBm)
> * 2422 MHz [3] (30.0 dBm)
> * 2427 MHz [4] (30.0 dBm)
> * 2432 MHz [5] (30.0 dBm)
> * 2437 MHz [6] (30.0 dBm)
> * 2442 MHz [7] (30.0 dBm)
> * 2447 MHz [8] (30.0 dBm)
> * 2452 MHz [9] (30.0 dBm)
> * 2457 MHz [10] (30.0 dBm)
> * 2462 MHz [11] (30.0 dBm)
> * 2467 MHz [12] (disabled)
> * 2472 MHz [13] (disabled)
> * 2484 MHz [14] (disabled)
>
> Also, as the commit 1b499cb72f26b
> ("mwifiex: disable channel filtering feature in firmware"), it proved to
> be a feature to get better scan result from overlapping channel.
>
> Even there could be AP from overlapping channel (might be 12/13/14
> in this case), it will be filtered depend on reg domain rules.
> e.g:
> ...
> if (ch->flags & IEEE80211_CHAN_DISABLED)
> continue;
>
> So it should not been an ERROR, use the WARN level to instead it for now.
>
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
> Acked-by: Xinming Hu <huxm@marvell.com>
Patch applied to wireless-drivers-next.git, thanks.
421ba82c676b mwifiex: fixes the unexpected be printed log by default
--
https://patchwork.kernel.org/patch/9786123/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2017-06-21 16:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 11:06 [PATCH v2] mwifiex: fixes the unexpected be printed log by default Caesar Wang
2017-06-21 15:25 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170621152520.5B96060250@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=amitkarwar@gmail.com \
--cc=briannorris@chromium.org \
--cc=gbhat@marvell.com \
--cc=huxm@marvell.com \
--cc=jeffy.chen@rock-chips.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nishants@marvell.com \
--cc=wxt@rock-chips.com \
--cc=yangzy@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).