From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Ricardo Leitner Subject: Re: [PATCH v2] net/sctp/ulpevent.c: Deinline sctp_ulpevent_set_owner, save 1616 bytes Date: Wed, 21 Jun 2017 16:24:42 -0300 Message-ID: <20170621192442.GH18138@localhost.localdomain> References: <20170621170327.4873-1-dvlasenk@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, Vlad Yasevich , Neil Horman , David Miller , linux-sctp@vger.kernel.org, netdev@vger.kernel.org To: Denys Vlasenko Return-path: Content-Disposition: inline In-Reply-To: <20170621170327.4873-1-dvlasenk@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Wed, Jun 21, 2017 at 07:03:27PM +0200, Denys Vlasenko wrote: > This function compiles to 147 bytes of machine code. 13 callsites. > > I'm no expert on SCTP events, but quick reading of SCTP docs tells me that > SCTP events are not happening on every packet. > They are ASSOC_CHANGE, PEER_ADDR_CHANGE, REMOTE_ERROR and such. > Does not look performance critical. > > Signed-off-by: Denys Vlasenko > CC: Vlad Yasevich > CC: Neil Horman > CC: David Miller > CC: linux-sctp@vger.kernel.org > CC: netdev@vger.kernel.org > CC: linux-kernel@vger.kernel.org Acked-by: Marcelo Ricardo Leitner Just wondering, are you conducting further research on this topic? Because we probably could use such review on SCTP stack. > --- > Changed since v1: > * reindented function argument list > > net/sctp/ulpevent.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/sctp/ulpevent.c b/net/sctp/ulpevent.c > index ec2b3e0..bc3f495 100644 > --- a/net/sctp/ulpevent.c > +++ b/net/sctp/ulpevent.c > @@ -88,8 +88,8 @@ int sctp_ulpevent_is_notification(const struct sctp_ulpevent *event) > /* Hold the association in case the msg_name needs read out of > * the association. > */ > -static inline void sctp_ulpevent_set_owner(struct sctp_ulpevent *event, > - const struct sctp_association *asoc) > +static void sctp_ulpevent_set_owner(struct sctp_ulpevent *event, > + const struct sctp_association *asoc) > { > struct sctp_chunk *chunk = event->chunk; > struct sk_buff *skb; > -- > 1.8.3.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sctp" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >