From: David Miller <davem@davemloft.net>
To: nfont@linux.vnet.ibm.com
Cc: netdev@vger.kernel.org, jallen@linux.vnet.ibm.com,
tlfalcon@linux.vnet.ibm.com
Subject: Re: [PATCH net-next V2] ibmvnic: Correct return code checking for ibmvnic_init during probe
Date: Thu, 22 Jun 2017 11:32:40 -0400 (EDT) [thread overview]
Message-ID: <20170622.113240.459131569663342510.davem@davemloft.net> (raw)
In-Reply-To: <149807766247.32243.8342302161340985903.stgit@mudbug>
From: Nathan Fontenot <nfont@linux.vnet.ibm.com>
Date: Wed, 21 Jun 2017 15:41:02 -0500
> The update to ibmvnic_init to allow an EAGAIN return code broke
> the calling of ibmvnic_init from ibmvnic_probe. The code now
> will return from this point in the probe routine if anything
> other than EAGAIN is returned. The check should be to see if rc
> is non-zero and not equal to EAGAIN.
>
> Without this fix, the vNIC driver can return 0 (success) from
> its probe routine due to ibmvnic_init returning zero, but before
> completing the probe process and registering with the netdev layer.
>
> Fixes: 6a2fb0e99f9c (ibmvnic: driver initialization for kdump/kexec)
> Signed-off-by: Nathan Fontenot <nfont@linux.vnet.ibm.com>
Applied.
prev parent reply other threads:[~2017-06-22 15:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 20:41 [PATCH net-next V2] ibmvnic: Correct return code checking for ibmvnic_init during probe Nathan Fontenot
2017-06-22 15:32 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170622.113240.459131569663342510.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jallen@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nfont@linux.vnet.ibm.com \
--cc=tlfalcon@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).