From: Steffen Klassert <steffen.klassert@secunet.com>
To: <yossiku@mellanox.com>
Cc: <netdev@vger.kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
Yevgeny Kliteynik <kliteyn@mellanox.com>,
Boris Pismenny <borisp@mellanox.com>,
Ilan Tayari <ilant@mellanox.com>
Subject: Re: [PATCH net v2 2/2] esp6_offload: Fix IP6CB(skb)->nhoff for ESP GRO
Date: Thu, 22 Jun 2017 12:52:13 +0200 [thread overview]
Message-ID: <20170622105213.GW2631@secunet.com> (raw)
In-Reply-To: <1498120631-4291-2-git-send-email-yossiku@mellanox.com>
On Thu, Jun 22, 2017 at 11:37:11AM +0300, yossiku@mellanox.com wrote:
> From: Yossi Kuperman <yossiku@mellanox.com>
>
> IP6CB(skb)->nhoff is the offset of the nexthdr field in an IPv6
> header, unless there are extension headers present, in which case
> nhoff points to the nexthdr field of the last extension header.
>
> In non-GRO code path, nhoff is set by ipv6_rcv before any XFRM code
> is executed. Conversely, in GRO code path (when esp6_offload is loaded),
> nhoff is not set. The following functions fail to read the correct value
> and eventually the packet is dropped:
>
> xfrm6_transport_finish
> xfrm6_tunnel_input
> xfrm6_rcv_tnl
>
> Set nhoff to the proper offset of nexthdr in esp6_gro_receive.
>
> Fixes: 7785bba299a8 ("esp: Add a software GRO codepath")
> Signed-off-by: Yossi Kuperman <yossiku@mellanox.com>
Both patches applied, thanks for your work Yossi!
prev parent reply other threads:[~2017-06-22 10:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-22 8:37 [PATCH net v2 1/2] xfrm6: Fix IPv6 payload_len in xfrm6_transport_finish yossiku
2017-06-22 8:37 ` [PATCH net v2 2/2] esp6_offload: Fix IP6CB(skb)->nhoff for ESP GRO yossiku
2017-06-22 10:52 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170622105213.GW2631@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=borisp@mellanox.com \
--cc=herbert@gondor.apana.org.au \
--cc=ilant@mellanox.com \
--cc=kliteyn@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=yossiku@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).