From: David Miller <davem@davemloft.net>
To: julien@arista.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] ipmr: restrict mroute "queue full" warning to related error values
Date: Fri, 23 Jun 2017 13:39:47 -0400 (EDT) [thread overview]
Message-ID: <20170623.133947.433422648753848462.davem@davemloft.net> (raw)
In-Reply-To: <20170621175811.16940-1-julien@arista.com>
From: Julien Gomes <julien@arista.com>
Date: Wed, 21 Jun 2017 10:58:10 -0700
> When sending a cache report on mroute_sk, mroute will emit a
> "pending queue full" warning for every error value returned by
> sock_queue_rcv_skb().
> This warning can be misleading, for example on the EPERM error value
> that sk_filter() can return.
>
> Restricting this warning to only ENOMEM or ENOBUFS seems more
> appropriate.
>
> Signed-off-by: Julien Gomes <julien@arista.com>
Incorrect, no other error codes are possible.
We never attach a socket filter to these kernel internal sockets,
therefore sk_filter() is not even applicable in this analysis.
Therefore, -ENOBUFS and -ENOMEM are the only errors we can ever see
returned from sock_queue_rcv_skb().
This goes for your second patch as well.
next prev parent reply other threads:[~2017-06-23 17:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 17:58 [PATCH net-next 1/2] ipmr: restrict mroute "queue full" warning to related error values Julien Gomes
2017-06-21 17:58 ` [PATCH net-next 2/2] ip6mr: restrict mroute6 " Julien Gomes
2017-06-23 17:39 ` David Miller [this message]
2017-06-23 17:52 ` [PATCH net-next 1/2] ipmr: restrict mroute " Julien Gomes
2017-06-23 18:47 ` David Miller
2017-06-23 20:17 ` Julien Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170623.133947.433422648753848462.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=julien@arista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).