From: David Miller <davem@davemloft.net>
To: timur@codeaurora.org
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 2/3] net: qcom/emac: do not reset the EMAC during initialization
Date: Fri, 23 Jun 2017 14:00:31 -0400 (EDT) [thread overview]
Message-ID: <20170623.140031.865751442887165393.davem@davemloft.net> (raw)
In-Reply-To: <1498154732-19854-3-git-send-email-timur@codeaurora.org>
From: Timur Tabi <timur@codeaurora.org>
Date: Thu, 22 Jun 2017 13:05:31 -0500
> It doesn't make sense to reset the EMAC in the middle of initializing
> it during the probe.
>
> Tested-by: Richard Ruigrok <rruigrok@codeaurora.org>
> Signed-off-by: Timur Tabi <timur@codeaurora.org>
Why not?
What if the boot loader or something else left the chip in
a weird state?
I'm not applying this.
If it's correct, the explanation in this commit message need
to be imporved. The change must be better justified.
next prev parent reply other threads:[~2017-06-23 18:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-22 18:05 [PATCH 0/3] net: qcom/emac: various minor improvements Timur Tabi
2017-06-22 18:05 ` [PATCH 1/3] net: qcom/emac: add shutdown function Timur Tabi
2017-06-22 18:05 ` [PATCH 2/3] net: qcom/emac: do not reset the EMAC during initialization Timur Tabi
2017-06-23 18:00 ` David Miller [this message]
2017-06-23 18:37 ` Timur Tabi
2017-06-23 18:54 ` David Miller
2017-06-22 18:05 ` [PATCH 3/3] net: qcom/emac: add support for emulation systems Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170623.140031.865751442887165393.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).