From: Andrew Lunn <andrew@lunn.ch>
To: Yunsheng Lin <linyunsheng@huawei.com>
Cc: davem@davemloft.net, f.fainelli@gmail.com,
huangdaode@hisilicon.com, xuwei5@hisilicon.com,
liguozhu@hisilicon.com, Yisen.Zhuang@huawei.com,
gabriele.paoloni@huawei.com, john.garry@huawei.com,
linuxarm@huawei.com, salil.mehta@huawei.com,
lipeng321@huawei.com, tremyfr@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH NET 2/2] net: hns: Use phy_driver to setup Phy loopback
Date: Fri, 23 Jun 2017 06:05:44 +0200 [thread overview]
Message-ID: <20170623040544.GC5432@lunn.ch> (raw)
In-Reply-To: <d4130f27-6373-b909-e23f-4c26520a9093@huawei.com>
> what should the Mac driver do when it receive the error? I assume that it
> will return it to userspace. because the rtnl_lock ensure only one ethtool
> is executing, if the function return error, it means some bug in the mac
> driver, am I right?
Yes, return it. It could be there are other use cases of loopback,
which are not protected by the rtnl_lock.
Andrew
prev parent reply other threads:[~2017-06-23 4:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-22 8:53 [PATCH NET 2/2] net: hns: Use phy_driver to setup Phy loopback Lin Yun Sheng
2017-06-23 3:20 ` Andrew Lunn
2017-06-23 3:48 ` Yunsheng Lin
2017-06-23 4:05 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170623040544.GC5432@lunn.ch \
--to=andrew@lunn.ch \
--cc=Yisen.Zhuang@huawei.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=gabriele.paoloni@huawei.com \
--cc=huangdaode@hisilicon.com \
--cc=john.garry@huawei.com \
--cc=liguozhu@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=linyunsheng@huawei.com \
--cc=lipeng321@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=tremyfr@gmail.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).