* [PATCH net-next] net: dsa: mv88e6xxx: fix error code in mv88e6390_serdes_power()
@ 2017-06-23 15:17 Dan Carpenter
2017-06-24 3:21 ` Andrew Lunn
2017-06-25 15:40 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2017-06-23 15:17 UTC (permalink / raw)
To: Andrew Lunn; +Cc: Vivien Didelot, Florian Fainelli, netdev, kernel-janitors
We're accidentally returning the wrong variable. "cmode" is
uninitialized at this point so it causes a static checker warning.
Fixes: 6335e9f2446b ("net: dsa: mv88e6xxx: mv88e6390X SERDES support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/dsa/mv88e6xxx/serdes.c b/drivers/net/dsa/mv88e6xxx/serdes.c
index 411b4f522792..f3c01119b3d1 100644
--- a/drivers/net/dsa/mv88e6xxx/serdes.c
+++ b/drivers/net/dsa/mv88e6xxx/serdes.c
@@ -192,7 +192,7 @@ int mv88e6390_serdes_power(struct mv88e6xxx_chip *chip, int port, bool on)
err = mv88e6xxx_port_get_cmode(chip, port, &cmode);
if (err)
- return cmode;
+ return err;
switch (port) {
case 2:
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: dsa: mv88e6xxx: fix error code in mv88e6390_serdes_power()
2017-06-23 15:17 [PATCH net-next] net: dsa: mv88e6xxx: fix error code in mv88e6390_serdes_power() Dan Carpenter
@ 2017-06-24 3:21 ` Andrew Lunn
2017-06-25 15:40 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2017-06-24 3:21 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Vivien Didelot, Florian Fainelli, netdev, kernel-janitors
On Fri, Jun 23, 2017 at 06:17:04PM +0300, Dan Carpenter wrote:
> We're accidentally returning the wrong variable. "cmode" is
> uninitialized at this point so it causes a static checker warning.
>
> Fixes: 6335e9f2446b ("net: dsa: mv88e6xxx: mv88e6390X SERDES support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: dsa: mv88e6xxx: fix error code in mv88e6390_serdes_power()
2017-06-23 15:17 [PATCH net-next] net: dsa: mv88e6xxx: fix error code in mv88e6390_serdes_power() Dan Carpenter
2017-06-24 3:21 ` Andrew Lunn
@ 2017-06-25 15:40 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-06-25 15:40 UTC (permalink / raw)
To: dan.carpenter; +Cc: andrew, vivien.didelot, f.fainelli, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 23 Jun 2017 18:17:04 +0300
> We're accidentally returning the wrong variable. "cmode" is
> uninitialized at this point so it causes a static checker warning.
>
> Fixes: 6335e9f2446b ("net: dsa: mv88e6xxx: mv88e6390X SERDES support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-25 15:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-23 15:17 [PATCH net-next] net: dsa: mv88e6xxx: fix error code in mv88e6390_serdes_power() Dan Carpenter
2017-06-24 3:21 ` Andrew Lunn
2017-06-25 15:40 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).