From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: dheidler@suse.de, netdev@vger.kernel.org
Subject: Re: [PATCH net] net: prevent sign extension in dev_get_stats()
Date: Tue, 27 Jun 2017 14:51:31 -0400 (EDT) [thread overview]
Message-ID: <20170627.145131.1627364252295077432.davem@davemloft.net> (raw)
In-Reply-To: <1498572140.736.115.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 27 Jun 2017 07:02:20 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> Similar to the fix provided by Dominik Heidler in commit
> 9b3dc0a17d73 ("l2tp: cast l2tp traffic counter to unsigned")
> we need to take care of 32bit kernels in dev_get_stats().
>
> When using atomic_long_read(), we add a 'long' to u64 and
> might misinterpret high order bit, unless we cast to unsigned.
>
> Fixes: caf586e5f23ce ("net: add a core netdev->rx_dropped counter")
> Fixes: 015f0688f57ca ("net: net: add a core netdev->tx_dropped counter")
> Fixes: 6e7333d315a76 ("net: add rx_nohandler stat counter")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Jarod Wilson <jarod@redhat.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2017-06-27 18:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 14:29 [PATCH] l2tp: cast l2tp traffic counter to unsigned Dominik Heidler
2017-06-09 22:16 ` Stephen Hemminger
2017-06-10 0:29 ` Eric Dumazet
2017-06-10 20:13 ` David Miller
2017-06-27 14:02 ` [PATCH net] net: prevent sign extension in dev_get_stats() Eric Dumazet
2017-06-27 18:51 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170627.145131.1627364252295077432.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dheidler@suse.de \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).