netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: netdev@vger.kernel.org
Cc: oss-drivers@netronome.com, Jakub Kicinski <jakub.kicinski@netronome.com>
Subject: [PATCH net-next 04/14] nfp: remove unused nfp_cpp_area_check_range()
Date: Tue, 27 Jun 2017 00:50:18 -0700	[thread overview]
Message-ID: <20170627075028.4009-5-jakub.kicinski@netronome.com> (raw)
In-Reply-To: <20170627075028.4009-1-jakub.kicinski@netronome.com>

Remove unused nfp_cpp_area_check_range() function.

Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Simon Horman <simon.horman@netronome.com>
---
 .../net/ethernet/netronome/nfp/nfpcore/nfp_cpp.h    |  2 --
 .../ethernet/netronome/nfp/nfpcore/nfp_cppcore.c    | 21 ---------------------
 2 files changed, 23 deletions(-)

diff --git a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_cpp.h b/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_cpp.h
index 235dd023d9b9..5798adc57cbc 100644
--- a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_cpp.h
+++ b/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_cpp.h
@@ -242,8 +242,6 @@ int nfp_cpp_area_read(struct nfp_cpp_area *area, unsigned long offset,
 		      void *buffer, size_t length);
 int nfp_cpp_area_write(struct nfp_cpp_area *area, unsigned long offset,
 		       const void *buffer, size_t length);
-int nfp_cpp_area_check_range(struct nfp_cpp_area *area,
-			     unsigned long long offset, unsigned long size);
 const char *nfp_cpp_area_name(struct nfp_cpp_area *cpp_area);
 void *nfp_cpp_area_priv(struct nfp_cpp_area *cpp_area);
 struct nfp_cpp *nfp_cpp_area_cpp(struct nfp_cpp_area *cpp_area);
diff --git a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_cppcore.c b/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_cppcore.c
index 7d5d7293efed..04dd5758ecf5 100644
--- a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_cppcore.c
+++ b/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_cppcore.c
@@ -571,27 +571,6 @@ int nfp_cpp_area_write(struct nfp_cpp_area *area,
 }
 
 /**
- * nfp_cpp_area_check_range() - check if address range fits in CPP area
- * @area:	CPP area handle
- * @offset:	offset into CPP target
- * @length:	size of address range in bytes
- *
- * Check if address range fits within CPP area.  Return 0 if area
- * fits or -EFAULT on error.
- *
- * Return: 0, or -ERRNO
- */
-int nfp_cpp_area_check_range(struct nfp_cpp_area *area,
-			     unsigned long long offset, unsigned long length)
-{
-	if (offset < area->offset ||
-	    offset + length > area->offset + area->size)
-		return -EFAULT;
-
-	return 0;
-}
-
-/**
  * nfp_cpp_area_name() - return name of a CPP area
  * @cpp_area:	CPP area handle
  *
-- 
2.11.0

  parent reply	other threads:[~2017-06-27  7:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-27  7:50 [PATCH net-next 00/14] nfp: get_phys_port_name for representors and SR-IOV reorder Jakub Kicinski
2017-06-27  7:50 ` [PATCH net-next 01/14] nfp: explicitly check if application FW is loaded Jakub Kicinski
2017-06-27  7:50 ` [PATCH net-next 02/14] nfp: move area mapping helper into nfpcore Jakub Kicinski
2017-06-27  7:50 ` [PATCH net-next 03/14] nfp: add helper for mapping runtime symbols Jakub Kicinski
2017-06-27  7:50 ` Jakub Kicinski [this message]
2017-06-27  7:50 ` [PATCH net-next 05/14] nfp: add nfp_app cleanup callback and make flower use it Jakub Kicinski
2017-06-27  7:50 ` [PATCH net-next 06/14] nfp: spawn nfp_ports for PF and VF ports Jakub Kicinski
2017-06-27  7:50 ` [PATCH net-next 07/14] nfp: make the representor get stats app-independent Jakub Kicinski
2017-06-27  7:50 ` [PATCH net-next 08/14] nfp: move representors' struct net_device_ops to shared code Jakub Kicinski
2017-06-27  7:50 ` [PATCH net-next 09/14] nfp: allow converting representor's netdev into nfp_port Jakub Kicinski
2017-06-27  7:50 ` [PATCH net-next 10/14] nfp: wire get_phys_port_name on representors Jakub Kicinski
2017-06-27  7:50 ` [PATCH net-next 11/14] nfp: handle SR-IOV already enabled when driver is probing Jakub Kicinski
2017-06-27  7:50 ` [PATCH net-next 12/14] nfp: reorder SR-IOV config and nfp_app SR-IOV callbacks Jakub Kicinski
2017-06-27  7:50 ` [PATCH net-next 13/14] nfp: allocate a private workqueue for driver work Jakub Kicinski
2017-06-27  7:50 ` [PATCH net-next 14/14] nfp: flower: add Kconfig for flower app Jakub Kicinski
2017-06-27 19:51 ` [PATCH net-next 00/14] nfp: get_phys_port_name for representors and SR-IOV reorder David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170627075028.4009-5-jakub.kicinski@netronome.com \
    --to=jakub.kicinski@netronome.com \
    --cc=netdev@vger.kernel.org \
    --cc=oss-drivers@netronome.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).