From: Kalle Valo <kvalo@codeaurora.org>
To: Colin Ian King <colin.king@canonical.com>
Cc: Igor Mitsyanko <imitsyanko@quantenna.com>,
Avinash Patil <avinashp@quantenna.com>,
Sergey Matyukevich <smatyukevich@quantenna.com>,
"David S . Miller" <davem@davemloft.net>,
Bindu Therthala <btherthala@quantenna.com>,
Kamlesh Rath <krath@quantenna.com>,
Sergei Maksimenko <smaksimenko@quantenna.com>,
Johannes Berg <johannes.berg@intel.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [net-next] qtnfmac: fix uninitialized return code in ret
Date: Wed, 28 Jun 2017 17:50:30 +0000 (UTC) [thread overview]
Message-ID: <20170628175030.F05F460AFB@smtp.codeaurora.org> (raw)
In-Reply-To: <20170621132530.11937-1-colin.king@canonical.com>
Colin Ian King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The return value ret is unitialized and garbage is being returned
> for the three different error conditions when setting up the PCIe
> BARs. Fix this by initializing ret to -ENOMEM to indicate that
> the BARs failed to be setup correctly.
>
> Detected by CoverityScan, CID#1437563 ("Unitialized scalar variable")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Reviewed-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
Patch applied to wireless-drivers-next.git, thanks.
3e3d8aa61107 qtnfmac: fix uninitialized return code in ret
--
https://patchwork.kernel.org/patch/9801833/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2017-06-28 17:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 13:25 [PATCH][net-next] qtnfmac: fix uninitialized return code in ret Colin King
2017-06-21 13:54 ` Sergey Matyukevich
2017-06-21 13:55 ` Colin Ian King
2017-06-22 5:10 ` Dan Carpenter
2017-06-22 8:24 ` Sergey Matyukevich
2017-06-28 17:50 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170628175030.F05F460AFB@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=avinashp@quantenna.com \
--cc=btherthala@quantenna.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=imitsyanko@quantenna.com \
--cc=johannes.berg@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=krath@quantenna.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=smaksimenko@quantenna.com \
--cc=smatyukevich@quantenna.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).