From: Jakub Kicinski <kubakici@wp.pl>
To: Dustin Byford <dustin@cumulusnetworks.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Roopa Prabhu <roopa@cumulusnetworks.com>,
davem@davemloft.net, linville@tuxdriver.com,
netdev@vger.kernel.org, vidya.chowdary@gmail.com,
olson@cumulusnetworks.com, leedom@chelsio.com,
manojmalviya@chelsio.com, santosh@chelsio.com,
yuval.mintz@qlogic.com, odedw@mellanox.com, ariela@mellanox.com,
galp@mellanox.com, jeffrey.t.kirsher@intel.com
Subject: Re: [PATCH net-next 1/3] net: ethtool: add support for forward error correction modes
Date: Wed, 28 Jun 2017 18:00:08 -0700 [thread overview]
Message-ID: <20170628180008.42059797@cakuba.netronome.com> (raw)
In-Reply-To: <20170628214751.shjgnh2mv7ihgcum@cumulusnetworks.com>
On Wed, 28 Jun 2017 14:47:51 -0700, Dustin Byford wrote:
> Hi Andrew,
>
> On Wed Jun 28 15:41, Andrew Lunn wrote:
> > On Tue, Jun 27, 2017 at 03:22:39AM -0700, Jakub Kicinski wrote:
> > > On Sat, 24 Jun 2017 12:19:43 -0700, Roopa Prabhu wrote:
> > > > Encoding: Types of encoding
> > > > Off : Turning off any encoding
> > > > RS : enforcing RS-FEC encoding on supported speeds
> > > > BaseR : enforcing Base R encoding on supported speeds
> > > > Auto : IEEE defaults for the speed/medium combination
> > >
> > > Just to be sure - does auto mean autonegotiate as defined by IEEE or
> > > some presets?
> >
> > I don't know this field very well. Is this confusion likely to happen
> > a lot? Is there a better name for Auto which is less likely to be
> > confused?
>
> You're not the first, or the second to ask that question. I agree it
> could use clarification.
>
> I always read auto in this context as automatic rather than autoneg.
> The best I can come up with is to perhaps fully spell out "automatic" in
> the documentation and the associated uapi enums. It's accurate, and
> hopefully different enough from "autoneg" to hint people away from the
> IEEE autoneg concept.
So perhaps just "default"? Even saying something like ieee-selected
doesn't really help, because apparently there are two autonegs defined
- IEEE one and a "consortium" one...
next prev parent reply other threads:[~2017-06-29 1:00 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-24 19:19 [PATCH net-next 0/3] ethtool: support for forward error correction mode setting on a link Roopa Prabhu
2017-06-24 19:19 ` [PATCH net-next 1/3] net: ethtool: add support for forward error correction modes Roopa Prabhu
2017-06-25 13:38 ` Gal Pressman
2017-06-28 5:46 ` Dustin Byford
2017-06-29 15:49 ` Gal Pressman
2017-06-27 10:22 ` Jakub Kicinski
2017-06-28 6:27 ` Dustin Byford
2017-06-28 6:41 ` Jakub Kicinski
2017-06-28 13:41 ` Andrew Lunn
2017-06-28 21:47 ` Dustin Byford
2017-06-29 1:00 ` Jakub Kicinski [this message]
2017-07-06 18:53 ` Casey Leedom
2017-07-06 19:02 ` Jakub Kicinski
2017-07-06 21:06 ` Wyborny, Carolyn
2017-07-06 21:53 ` Casey Leedom
2017-07-06 22:16 ` Wyborny, Carolyn
2017-07-06 22:36 ` Andrew Lunn
2017-07-06 22:37 ` Casey Leedom
2017-07-06 22:33 ` Andrew Lunn
2017-07-06 22:47 ` Casey Leedom
2017-07-06 23:15 ` Andrew Lunn
2017-07-06 23:27 ` Jakub Kicinski
2017-07-06 23:39 ` Casey Leedom
2017-07-07 0:56 ` Andrew Lunn
2017-07-07 1:38 ` Dave Olson
2017-07-06 22:43 ` Jakub Kicinski
2017-07-06 22:57 ` Casey Leedom
2017-06-29 13:30 ` Andrew Lunn
2017-06-24 19:19 ` [PATCH net-next 2/3] cxgb4: core hardware/firmware support for Forward Error Correction on a link Roopa Prabhu
2017-06-27 3:16 ` David Miller
2017-06-24 19:19 ` [PATCH net-next 3/3] cxgb4: ethtool forward error correction management support Roopa Prabhu
2017-06-24 21:47 ` [PATCH net-next 0/3] ethtool: support for forward error correction mode setting on a link Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170628180008.42059797@cakuba.netronome.com \
--to=kubakici@wp.pl \
--cc=andrew@lunn.ch \
--cc=ariela@mellanox.com \
--cc=davem@davemloft.net \
--cc=dustin@cumulusnetworks.com \
--cc=galp@mellanox.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=leedom@chelsio.com \
--cc=linville@tuxdriver.com \
--cc=manojmalviya@chelsio.com \
--cc=netdev@vger.kernel.org \
--cc=odedw@mellanox.com \
--cc=olson@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
--cc=santosh@chelsio.com \
--cc=vidya.chowdary@gmail.com \
--cc=yuval.mintz@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).