From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Yunsheng Lin <linyunsheng@huawei.com>
Cc: Simon Horman <simon.horman@netronome.com>,
David Miller <davem@davemloft.net>, <netdev@vger.kernel.org>,
<oss-drivers@netronome.com>,
"Pieter Jansen van Vuuren" <pieter.jansenvanvuuren@netronome.com>
Subject: Re: [PATCH net-next v2 4/9] nfp: extend flower add flow offload
Date: Wed, 28 Jun 2017 23:48:29 -0700 [thread overview]
Message-ID: <20170628234829.76098a18@cakuba.netronome.com> (raw)
In-Reply-To: <ceb96fbd-c768-5bb2-cb44-f1bc7ecb4849@huawei.com>
On Thu, 29 Jun 2017 14:18:07 +0800, Yunsheng Lin wrote:
> > + if (mask_basic->n_proto) {
> cpu_to_be16（mask_basic->n_proto）
> remove cpu_to_be16 in case.
Thanks, but this is incorrect. Byte swapping constants is done at
compilation time - therefore it's preferred.
next prev parent reply other threads:[~2017-06-29 6:48 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 20:29 [PATCH net-next v2 0/9] introduce flower offload capabilities Simon Horman
2017-06-28 20:29 ` [PATCH net-next v2 1/9] net: switchdev: add SET_SWITCHDEV_OPS helper Simon Horman
2017-06-28 20:29 ` [PATCH net-next v2 2/9] nfp: add phys_switch_id support Simon Horman
2017-06-28 20:29 ` [PATCH net-next v2 3/9] nfp: provide infrastructure for offloading flower based TC filters Simon Horman
2017-06-29 1:35 ` Jakub Kicinski
2017-06-29 5:41 ` Simon Horman
2017-06-29 1:53 ` Jakub Kicinski
2017-06-29 8:16 ` Simon Horman
2017-06-29 13:56 ` Or Gerlitz
2017-06-29 14:31 ` Simon Horman
2017-06-28 20:29 ` [PATCH net-next v2 4/9] nfp: extend flower add flow offload Simon Horman
2017-06-29 6:18 ` Yunsheng Lin
2017-06-29 6:48 ` Jakub Kicinski [this message]
2017-06-29 13:47 ` David Laight
2017-06-28 20:29 ` [PATCH net-next v2 5/9] nfp: extend flower matching capabilities Simon Horman
2017-06-29 14:31 ` Or Gerlitz
2017-06-29 15:01 ` Simon Horman
2017-06-29 14:33 ` Or Gerlitz
2017-06-29 15:00 ` Simon Horman
2017-06-28 20:29 ` [PATCH net-next v2 6/9] nfp: add basic action capabilities to flower offloads Simon Horman
2017-06-28 20:30 ` [PATCH net-next v2 7/9] nfp: add metadata to each flow offload Simon Horman
2017-06-29 2:33 ` Jakub Kicinski
2017-06-29 8:14 ` [oss-drivers] " Simon Horman
2017-06-29 8:42 ` Jakub Kicinski
2017-06-29 11:22 ` Simon Horman
2017-06-28 20:30 ` [PATCH net-next v2 8/9] nfp: add a stats handler for flower offloads Simon Horman
2017-06-29 1:28 ` Jakub Kicinski
2017-06-29 8:14 ` [oss-drivers] " Simon Horman
2017-06-29 2:55 ` Jakub Kicinski
2017-06-29 8:15 ` [oss-drivers] " Simon Horman
2017-06-29 14:39 ` Or Gerlitz
2017-06-29 14:53 ` Simon Horman
2017-06-29 15:16 ` Or Gerlitz
2017-06-29 15:27 ` Simon Horman
2017-06-28 20:30 ` [PATCH net-next v2 9/9] nfp: add control message passing capabilities to " Simon Horman
2017-06-29 13:46 ` Or Gerlitz
2017-06-29 14:45 ` David Laight
2017-06-29 15:21 ` Or Gerlitz
2017-06-29 15:30 ` Simon Horman
2017-06-29 15:59 ` Or Gerlitz
2017-06-29 17:35 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170628234829.76098a18@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=davem@davemloft.net \
--cc=linyunsheng@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=pieter.jansenvanvuuren@netronome.com \
--cc=simon.horman@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).