From: David Miller <davem@davemloft.net>
To: xiangxia.m.yue@gmail.com
Cc: netdev@vger.kernel.org, pshelar@ovn.org, gvrose8192@gmail.com
Subject: Re: [PATCH net-next v3] datapath: Avoid using stack larger than 1024.
Date: Sat, 01 Jul 2017 09:10:55 -0700 (PDT) [thread overview]
Message-ID: <20170701.091055.4333181967829415.davem@davemloft.net> (raw)
In-Reply-To: <1498782464-47146-1-git-send-email-nic@opencloud.tech>
From: nickcooper-zhangtonghao <xiangxia.m.yue@gmail.com>
Date: Thu, 29 Jun 2017 17:27:44 -0700
> From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
>
> When compiling OvS-master on 4.4.0-81 kernel,
> there is a warning:
>
> CC [M] /root/ovs/datapath/linux/datapath.o
> /root/ovs/datapath/linux/datapath.c: In function
> 'ovs_flow_cmd_set':
> /root/ovs/datapath/linux/datapath.c:1221:1: warning:
> the frame size of 1040 bytes is larger than 1024 bytes
> [-Wframe-larger-than=]
>
> This patch factors out match-init and action-copy to avoid
> "Wframe-larger-than=1024" warning. Because mask is only
> used to get actions, we new a function to save some
> stack space.
>
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> Acked-by: Pravin B Shelar <pshelar@ovn.org>
Applied.
prev parent reply other threads:[~2017-07-01 16:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 0:27 [PATCH net-next v3] datapath: Avoid using stack larger than 1024 nickcooper-zhangtonghao
2017-07-01 16:10 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170701.091055.4333181967829415.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gvrose8192@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
--cc=xiangxia.m.yue@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).