From: David Miller <davem@davemloft.net>
To: ivan.briano@intel.com
Cc: netdev@vger.kernel.org, jesus.sanchez-palencia@intel.com,
vinicius.gomes@intel.com, andre.guedes@intel.com
Subject: Re: [PATCH net-next] net/packet: Fix Tx queue selection for AF_PACKET
Date: Mon, 03 Jul 2017 02:18:58 -0700 (PDT) [thread overview]
Message-ID: <20170703.021858.1360397700923467821.davem@davemloft.net> (raw)
In-Reply-To: <20170630210232.18407-1-ivan.briano@intel.com>
From: Iván Briano <ivan.briano@intel.com>
Date: Fri, 30 Jun 2017 14:02:32 -0700
> When PACKET_QDISC_BYPASS is not used, Tx queue selection will be done
> before the packet is enqueued, taking into account any mappings set by
> a queuing discipline such as mqprio without hardware offloading. This
> selection may be affected by a previously saved queue_mapping, either on
> the Rx path, or done before the packet reaches the device, as it's
> currently the case for AF_PACKET.
>
> In order for queue selection to work as expected when using traffic
> control, there can't be another selection done before that point is
> reached, so move the call to packet_pick_tx_queue to
> packet_direct_xmit, leaving the default xmit path as it was before
> PACKET_QDISC_BYPASS was introduced.
>
> A forward declaration of packet_pick_tx_queue() is introduced to avoid
> the need to reorder the functions within the file.
>
> Signed-off-by: Iván Briano <ivan.briano@intel.com>
Please resubmit tihs with a proper "Fixes: " tag which shows what
commit introduced this problem.
Thanks.
prev parent reply other threads:[~2017-07-03 9:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 21:02 [PATCH net-next] net/packet: Fix Tx queue selection for AF_PACKET Iván Briano
2017-07-03 9:18 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170703.021858.1360397700923467821.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andre.guedes@intel.com \
--cc=ivan.briano@intel.com \
--cc=jesus.sanchez-palencia@intel.com \
--cc=netdev@vger.kernel.org \
--cc=vinicius.gomes@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).