* [PATCH net] mpls: fix rtm policy in mpls_getroute
@ 2017-07-05 0:03 Roopa Prabhu
2017-07-05 8:06 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Roopa Prabhu @ 2017-07-05 0:03 UTC (permalink / raw)
To: davem; +Cc: netdev, dsahern, rshearma, nikolay
From: Roopa Prabhu <roopa@cumulusnetworks.com>
fix rtm policy name typo in mpls_getroute and also remove
export of rtm_ipv4_policy
Fixes: 397fc9e5cefe ("mpls: route get support")
Reported-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
---
David, since the rtm_ipv4_policy export is not in net yet
and assuming it will soon be there, I have generated this
patch against net-next, but addressed it to net. Thanks.
net/ipv4/fib_frontend.c | 1 -
net/mpls/af_mpls.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c
index 1b5860f..4e678fa 100644
--- a/net/ipv4/fib_frontend.c
+++ b/net/ipv4/fib_frontend.c
@@ -626,7 +626,6 @@ int ip_rt_ioctl(struct net *net, unsigned int cmd, void __user *arg)
[RTA_UID] = { .type = NLA_U32 },
[RTA_MARK] = { .type = NLA_U32 },
};
-EXPORT_SYMBOL_GPL(rtm_ipv4_policy);
static int rtm_to_fib_config(struct net *net, struct sk_buff *skb,
struct nlmsghdr *nlh, struct fib_config *cfg,
diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c
index e17d6cd..bdcfb2d 100644
--- a/net/mpls/af_mpls.c
+++ b/net/mpls/af_mpls.c
@@ -2091,7 +2091,7 @@ static int mpls_getroute(struct sk_buff *in_skb, struct nlmsghdr *in_nlh,
u8 n_labels;
err = nlmsg_parse(in_nlh, sizeof(*rtm), tb, RTA_MAX,
- rtm_ipv4_policy, extack);
+ rtm_mpls_policy, extack);
if (err < 0)
goto errout;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] mpls: fix rtm policy in mpls_getroute
2017-07-05 0:03 [PATCH net] mpls: fix rtm policy in mpls_getroute Roopa Prabhu
@ 2017-07-05 8:06 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-07-05 8:06 UTC (permalink / raw)
To: roopa; +Cc: netdev, dsahern, rshearma, nikolay
From: Roopa Prabhu <roopa@cumulusnetworks.com>
Date: Tue, 4 Jul 2017 17:03:02 -0700
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>
> fix rtm policy name typo in mpls_getroute and also remove
> export of rtm_ipv4_policy
>
> Fixes: 397fc9e5cefe ("mpls: route get support")
> Reported-by: David S. Miller <davem@davemloft.net>
> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
> ---
> David, since the rtm_ipv4_policy export is not in net yet
> and assuming it will soon be there, I have generated this
> patch against net-next, but addressed it to net. Thanks.
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-05 8:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-05 0:03 [PATCH net] mpls: fix rtm policy in mpls_getroute Roopa Prabhu
2017-07-05 8:06 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).