From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: ast@kernel.org, daniel@iogearbox.net, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][bpf-next] bpf: add missing break in for the TCP_BPF_SNDCWND_CLAMP case
Date: Wed, 05 Jul 2017 09:09:08 +0100 (WEST) [thread overview]
Message-ID: <20170705.090908.458530250899642598.davem@davemloft.net> (raw)
In-Reply-To: <20170704152112.18623-1-colin.king@canonical.com>
From: Colin King <colin.king@canonical.com>
Date: Tue, 4 Jul 2017 16:21:12 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> There appears to be a missing break in the TCP_BPF_SNDCWND_CLAMP case.
> Currently the non-error path where val is greater than zero falls through
> to the default case that sets the error return to -EINVAL. Add in
> the missing break.
>
> Detected by CoverityScan, CID#1449376 ("Missing break in switch")
>
> Fixes: 13bf96411ad2 ("bpf: Adds support for setting sndcwnd clamp")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
prev parent reply other threads:[~2017-07-05 8:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 15:21 [PATCH][bpf-next] bpf: add missing break in for the TCP_BPF_SNDCWND_CLAMP case Colin King
2017-07-04 15:26 ` Daniel Borkmann
2017-07-04 18:26 ` Lawrence Brakmo
2017-07-05 8:09 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170705.090908.458530250899642598.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ast@kernel.org \
--cc=colin.king@canonical.com \
--cc=daniel@iogearbox.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).