From: Jiri Pirko <jiri@resnulli.us>
To: Robert McCabe <robert.mccabe@rockwellcollins.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/1] net sched: Added the TC_LINKLAYER_CUSTOM linklayer type
Date: Wed, 5 Jul 2017 09:01:33 +0200 [thread overview]
Message-ID: <20170705070133.GA1850@nanopsycho> (raw)
In-Reply-To: <CAA0ESdojQfya_PTo=hJeCX1U6ReJ8L2sBra9wUW4LfGwzLYW_A@mail.gmail.com>
Tue, Jul 04, 2017 at 07:12:47PM CEST, robert.mccabe@rockwellcollins.com wrote:
>>>Even so, the kernel patch you sent does not make any sense. Introduces
>>>TC_LINKLAYER_CUSTOM but does not use it.
>
>I needed to add this to the tc_link_layer enum in my iproute2 patch
>(https://patchwork.ozlabs.org/patch/784165/)
>
>enum tc_link_layer {
> TC_LINKLAYER_UNAWARE, /* Indicate unaware old iproute2 util */
> TC_LINKLAYER_ETHERNET,
> TC_LINKLAYER_ATM,
> + TC_LINKLAYER_CUSTOM,
> };
>
>I originally wasn't aware that this file was shared with the kernel --
>my original patch received the comment from Eric Dumazet
>
> You can not do this : This file is coming from the kernel
> ( include/uapi/linux/pkt_sched.h )
Correct.
>
>So I opted to make the corresponding change to the pkt_sched.h file in
>the kernel.
I'm not sure how should I put this, but you are adding enum value and
you are not using it in kernel! That is wrong. Whenever you add new
value to UAPI, it has to have a point. Please see:
$ git grep TC_LINKLAYER_
>But looking at it further, I am confused as to why this tc_link_layer even needs
>to exist in the kernel anyway, It is only used in net/sched for calculating the
>size (via stab) and rate (via rtab) translations; however, these
>translations are
>already specified with in the form of the stab and rtab themselves (these are
>calculated in userspace).
>
>I think -- in a perfect world -- the tc_link_layer (and the associated
>tc_ratespec.linklayer and tc_sizespec.linklayer) should be removed
>from the kernel,
>but I'm not sure of the compatibility implications of this ...
>Do you have any suggestions?
>
>>
>> Also, please make you email working. Says to me:
>>
>> ** Address not found **
>>
>> Your message wasn't delivered to McCabe@rockwellcollins.com because the address couldn't be found. Check for typos or unnecessary spaces and try again.
>>
>> This is annoying.
>
>I think I fixed it -- was mis-configuration in my .gitconfig (sorry,
>I'm still new at this).
next prev parent reply other threads:[~2017-07-05 7:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 0:14 [PATCH 1/1] net sched: Added the TC_LINKLAYER_CUSTOM linklayer type McCabe, Robert J
2017-07-04 0:14 ` [PATCH 1/1] tc: custom qdisc pkt size translation table McCabe, Robert J
2017-07-04 5:48 ` [PATCH 1/1] net sched: Added the TC_LINKLAYER_CUSTOM linklayer type Jiri Pirko
2017-07-04 14:49 ` Robert McCabe
2017-07-04 15:34 ` Jiri Pirko
2017-07-04 15:40 ` Jiri Pirko
2017-07-04 17:12 ` Robert McCabe
2017-07-05 7:01 ` Jiri Pirko [this message]
2017-07-06 9:03 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170705070133.GA1850@nanopsycho \
--to=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=robert.mccabe@rockwellcollins.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).