* [PATCH net-next 1/1] net sched actions: rename act_get_notify() to tcf_get_notify()
@ 2017-07-05 19:33 Roman Mashak
2017-07-05 20:31 ` Jiri Pirko
0 siblings, 1 reply; 3+ messages in thread
From: Roman Mashak @ 2017-07-05 19:33 UTC (permalink / raw)
To: davem; +Cc: netdev, Roman Mashak
Make name consistent with other TC event notification routines.
Signed-off-by: Roman Mashak <mrv@mojatatu.com>
---
net/sched/act_api.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/sched/act_api.c b/net/sched/act_api.c
index aed6cf2..f2e9ed3 100644
--- a/net/sched/act_api.c
+++ b/net/sched/act_api.c
@@ -835,7 +835,7 @@ static int tca_get_fill(struct sk_buff *skb, struct list_head *actions,
}
static int
-act_get_notify(struct net *net, u32 portid, struct nlmsghdr *n,
+tcf_get_notify(struct net *net, u32 portid, struct nlmsghdr *n,
struct list_head *actions, int event)
{
struct sk_buff *skb;
@@ -1018,7 +1018,7 @@ static int tca_action_flush(struct net *net, struct nlattr *nla,
}
if (event == RTM_GETACTION)
- ret = act_get_notify(net, portid, n, &actions, event);
+ ret = tcf_get_notify(net, portid, n, &actions, event);
else { /* delete */
ret = tcf_del_notify(net, n, &actions, portid);
if (ret)
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next 1/1] net sched actions: rename act_get_notify() to tcf_get_notify()
2017-07-05 19:33 [PATCH net-next 1/1] net sched actions: rename act_get_notify() to tcf_get_notify() Roman Mashak
@ 2017-07-05 20:31 ` Jiri Pirko
2017-07-05 21:13 ` Roman Mashak
0 siblings, 1 reply; 3+ messages in thread
From: Jiri Pirko @ 2017-07-05 20:31 UTC (permalink / raw)
To: Roman Mashak; +Cc: davem, netdev
Wed, Jul 05, 2017 at 09:33:58PM CEST, mrv@mojatatu.com wrote:
>Make name consistent with other TC event notification routines.
>
>Signed-off-by: Roman Mashak <mrv@mojatatu.com>
>---
> net/sched/act_api.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/net/sched/act_api.c b/net/sched/act_api.c
>index aed6cf2..f2e9ed3 100644
>--- a/net/sched/act_api.c
>+++ b/net/sched/act_api.c
>@@ -835,7 +835,7 @@ static int tca_get_fill(struct sk_buff *skb, struct list_head *actions,
> }
>
> static int
>-act_get_notify(struct net *net, u32 portid, struct nlmsghdr *n,
>+tcf_get_notify(struct net *net, u32 portid, struct nlmsghdr *n,
Rather call it "tcf_action_get_notify"
+ net-next is closed if I'm not mistaken
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next 1/1] net sched actions: rename act_get_notify() to tcf_get_notify()
2017-07-05 20:31 ` Jiri Pirko
@ 2017-07-05 21:13 ` Roman Mashak
0 siblings, 0 replies; 3+ messages in thread
From: Roman Mashak @ 2017-07-05 21:13 UTC (permalink / raw)
To: Jiri Pirko; +Cc: davem, netdev
Jiri Pirko <jiri@resnulli.us> writes:
> Wed, Jul 05, 2017 at 09:33:58PM CEST, mrv@mojatatu.com wrote:
>>Make name consistent with other TC event notification routines.
>>
>>Signed-off-by: Roman Mashak <mrv@mojatatu.com>
>>---
>> net/sched/act_api.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>>diff --git a/net/sched/act_api.c b/net/sched/act_api.c
>>index aed6cf2..f2e9ed3 100644
>>--- a/net/sched/act_api.c
>>+++ b/net/sched/act_api.c
>>@@ -835,7 +835,7 @@ static int tca_get_fill(struct sk_buff *skb, struct list_head *actions,
>> }
>>
>> static int
>>-act_get_notify(struct net *net, u32 portid, struct nlmsghdr *n,
>>+tcf_get_notify(struct net *net, u32 portid, struct nlmsghdr *n,
>
> Rather call it "tcf_action_get_notify"
We already have tcf_add_notify() and tcf_del_notify() as a common style.
>
> + net-next is closed if I'm not mistaken
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-05 21:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-05 19:33 [PATCH net-next 1/1] net sched actions: rename act_get_notify() to tcf_get_notify() Roman Mashak
2017-07-05 20:31 ` Jiri Pirko
2017-07-05 21:13 ` Roman Mashak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).