From: Lennert Buytenhek <buytenh@wantstofly.org>
To: David Ahern <dsahern@gmail.com>,
Roopa Prabhu <roopa@cumulusnetworks.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Robert Shearman <rshearma@brocade.com>
Subject: Re: [PATCH net] net: ipv6: Compare lwstate in detecting duplicate nexthops
Date: Thu, 6 Jul 2017 00:38:46 +0300 [thread overview]
Message-ID: <20170705213846.GP22185@wantstofly.org> (raw)
In-Reply-To: <CAJieiUji4hOeRXZoCXfiC6p5NYzeqO_Ou0RYzarX2afXgLzcqA@mail.gmail.com>
On Wed, Jul 05, 2017 at 02:14:33PM -0700, Roopa Prabhu wrote:
> > Lennert reported a failure to add different mpls encaps in a multipath
> > route:
> >
> > $ ip -6 route add 1234::/16 \
> > nexthop encap mpls 10 via fe80::1 dev ens3 \
> > nexthop encap mpls 20 via fe80::1 dev ens3
> > RTNETLINK answers: File exists
> >
> > The problem is that the duplicate nexthop detection does not compare
> > lwtunnel configuration. Add it.
> >
> > Fixes: 19e42e451506("ipv6: support for fib route lwtunnel encap attributes")
> > Signed-off-by: David Ahern <dsahern@gmail.com>
>
> Reported-by: João Taveira Araújo <joao.taveira@gmail.com>
>
> Reported-by: Lennert Buytenhek <buytenh@wantstofly.org>
>
> Acked-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Tested-by: Lennert Buytenhek <buytenh@wantstofly.org>
Seems to work! Thanks!
next prev parent reply other threads:[~2017-07-05 21:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 20:41 [PATCH net] net: ipv6: Compare lwstate in detecting duplicate nexthops David Ahern
2017-07-05 21:14 ` Roopa Prabhu
2017-07-05 21:38 ` Lennert Buytenhek [this message]
2017-07-06 9:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170705213846.GP22185@wantstofly.org \
--to=buytenh@wantstofly.org \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=rshearma@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).