* net/ipv4/tcp_ipv4.c:950:23: sparse: symbol 'tcp_md5_do_lookup_exact' was not declared. Should it be static?
@ 2017-07-05 23:58 kbuild test robot
2017-07-05 23:58 ` [RFC PATCH linus] tcp: md5: tcp_md5_do_lookup_exact() can be static kbuild test robot
0 siblings, 1 reply; 5+ messages in thread
From: kbuild test robot @ 2017-07-05 23:58 UTC (permalink / raw)
To: Ivan Delalande
Cc: kbuild-all, linux-kernel, Bob Gilligan, Eric Mowat,
Alexey Kuznetsov, James Morris, Hideaki YOSHIFUJI,
Patrick McHardy, netdev
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: b4b8cbf679c4866a523a35d1454884a31bd5d8dc
commit: 6797318e623da68dfbacd0cb5c246f5ecd2baf6e tcp: md5: add an address prefix for key lookup
date: 2 weeks ago
reproduce:
# apt-get install sparse
git checkout 6797318e623da68dfbacd0cb5c246f5ecd2baf6e
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
>> net/ipv4/tcp_ipv4.c:950:23: sparse: symbol 'tcp_md5_do_lookup_exact' was not declared. Should it be static?
net/ipv4/tcp_ipv4.c:1614:17: sparse: context imbalance in 'tcp_add_backlog' - unexpected unlock
net/ipv4/tcp_ipv4.c:1799:21: sparse: context imbalance in 'tcp_v4_rcv' - different lock contexts for basic block
net/ipv4/tcp_ipv4.c:1985:20: sparse: context imbalance in 'listening_get_next' - unexpected unlock
net/ipv4/tcp_ipv4.c:2045:9: sparse: context imbalance in 'established_get_first' - wrong count at exit
net/ipv4/tcp_ipv4.c:2065:40: sparse: context imbalance in 'established_get_next' - unexpected unlock
net/ipv4/tcp_ipv4.c:2193:36: sparse: context imbalance in 'tcp_seq_stop' - unexpected unlock
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 5+ messages in thread* [RFC PATCH linus] tcp: md5: tcp_md5_do_lookup_exact() can be static 2017-07-05 23:58 net/ipv4/tcp_ipv4.c:950:23: sparse: symbol 'tcp_md5_do_lookup_exact' was not declared. Should it be static? kbuild test robot @ 2017-07-05 23:58 ` kbuild test robot 2017-07-06 0:27 ` Stephen Rothwell 0 siblings, 1 reply; 5+ messages in thread From: kbuild test robot @ 2017-07-05 23:58 UTC (permalink / raw) To: Stephen Rothwell Cc: kbuild-all, linux-kernel, Alexey Kuznetsov, James Morris, Hideaki YOSHIFUJI, Patrick McHardy, netdev Fixes: 0c5f0311f690 ("Add linux-next specific files for 20170705") Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> --- tcp_ipv4.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c index 6ec6900..a20e7f0 100644 --- a/net/ipv4/tcp_ipv4.c +++ b/net/ipv4/tcp_ipv4.c @@ -943,9 +943,9 @@ struct tcp_md5sig_key *tcp_md5_do_lookup(const struct sock *sk, } EXPORT_SYMBOL(tcp_md5_do_lookup); -struct tcp_md5sig_key *tcp_md5_do_lookup_exact(const struct sock *sk, - const union tcp_md5_addr *addr, - int family, u8 prefixlen) +static struct tcp_md5sig_key *tcp_md5_do_lookup_exact(const struct sock *sk, + const union tcp_md5_addr *addr, + int family, u8 prefixlen) { const struct tcp_sock *tp = tcp_sk(sk); struct tcp_md5sig_key *key; ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [RFC PATCH linus] tcp: md5: tcp_md5_do_lookup_exact() can be static 2017-07-05 23:58 ` [RFC PATCH linus] tcp: md5: tcp_md5_do_lookup_exact() can be static kbuild test robot @ 2017-07-06 0:27 ` Stephen Rothwell 2017-07-06 8:57 ` Fengguang Wu 2017-07-06 9:55 ` David Miller 0 siblings, 2 replies; 5+ messages in thread From: Stephen Rothwell @ 2017-07-06 0:27 UTC (permalink / raw) To: kbuild test robot Cc: kbuild-all, linux-kernel, Alexey Kuznetsov, James Morris, Hideaki YOSHIFUJI, Patrick McHardy, netdev, Ivan Delalande, David S. Miller, Bob Gilligan, Eric Mowat Hi, Not sure why you sent this to me ... it fixes a commit in the net-next tree (now in Linus' tree) ... On Thu, 6 Jul 2017 07:58:53 +0800 kbuild test robot <fengguang.wu@intel.com> wrote: > > Fixes: 0c5f0311f690 ("Add linux-next specific files for 20170705") Actually: Fixes: 6797318e623d ("tcp: md5: add an address prefix for key lookup") > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > --- > tcp_ipv4.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c > index 6ec6900..a20e7f0 100644 > --- a/net/ipv4/tcp_ipv4.c > +++ b/net/ipv4/tcp_ipv4.c > @@ -943,9 +943,9 @@ struct tcp_md5sig_key *tcp_md5_do_lookup(const struct sock *sk, > } > EXPORT_SYMBOL(tcp_md5_do_lookup); > > -struct tcp_md5sig_key *tcp_md5_do_lookup_exact(const struct sock *sk, > - const union tcp_md5_addr *addr, > - int family, u8 prefixlen) > +static struct tcp_md5sig_key *tcp_md5_do_lookup_exact(const struct sock *sk, > + const union tcp_md5_addr *addr, > + int family, u8 prefixlen) > { > const struct tcp_sock *tp = tcp_sk(sk); > struct tcp_md5sig_key *key; -- Cheers, Stephen Rothwell ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFC PATCH linus] tcp: md5: tcp_md5_do_lookup_exact() can be static 2017-07-06 0:27 ` Stephen Rothwell @ 2017-07-06 8:57 ` Fengguang Wu 2017-07-06 9:55 ` David Miller 1 sibling, 0 replies; 5+ messages in thread From: Fengguang Wu @ 2017-07-06 8:57 UTC (permalink / raw) To: Stephen Rothwell Cc: kbuild-all, linux-kernel, Alexey Kuznetsov, James Morris, Hideaki YOSHIFUJI, Patrick McHardy, netdev, Ivan Delalande, David S. Miller, Bob Gilligan, Eric Mowat Hi Stephen, On Thu, Jul 06, 2017 at 10:27:12AM +1000, Stephen Rothwell wrote: >Hi, > >Not sure why you sent this to me ... it fixes a commit in the net-next >tree (now in Linus' tree) ... Yeah sorry -- it's a bug in the robot. >On Thu, 6 Jul 2017 07:58:53 +0800 kbuild test robot <fengguang.wu@intel.com> wrote: >> >> Fixes: 0c5f0311f690 ("Add linux-next specific files for 20170705") > >Actually: Fixes: 6797318e623d ("tcp: md5: add an address prefix for key lookup") Yeah, fixed the robot. Thank you for the reminder! Regards, Fengguang >> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> >> --- >> tcp_ipv4.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c >> index 6ec6900..a20e7f0 100644 >> --- a/net/ipv4/tcp_ipv4.c >> +++ b/net/ipv4/tcp_ipv4.c >> @@ -943,9 +943,9 @@ struct tcp_md5sig_key *tcp_md5_do_lookup(const struct sock *sk, >> } >> EXPORT_SYMBOL(tcp_md5_do_lookup); >> >> -struct tcp_md5sig_key *tcp_md5_do_lookup_exact(const struct sock *sk, >> - const union tcp_md5_addr *addr, >> - int family, u8 prefixlen) >> +static struct tcp_md5sig_key *tcp_md5_do_lookup_exact(const struct sock *sk, >> + const union tcp_md5_addr *addr, >> + int family, u8 prefixlen) >> { >> const struct tcp_sock *tp = tcp_sk(sk); >> struct tcp_md5sig_key *key; > >-- >Cheers, >Stephen Rothwell ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFC PATCH linus] tcp: md5: tcp_md5_do_lookup_exact() can be static 2017-07-06 0:27 ` Stephen Rothwell 2017-07-06 8:57 ` Fengguang Wu @ 2017-07-06 9:55 ` David Miller 1 sibling, 0 replies; 5+ messages in thread From: David Miller @ 2017-07-06 9:55 UTC (permalink / raw) To: sfr Cc: fengguang.wu, kbuild-all, linux-kernel, kuznet, jmorris, yoshfuji, kaber, netdev, colona, gilligan, mowat From: Stephen Rothwell <sfr@canb.auug.org.au> Date: Thu, 6 Jul 2017 10:27:12 +1000 > Hi, > > Not sure why you sent this to me ... it fixes a commit in the net-next > tree (now in Linus' tree) ... > > On Thu, 6 Jul 2017 07:58:53 +0800 kbuild test robot <fengguang.wu@intel.com> wrote: >> >> Fixes: 0c5f0311f690 ("Add linux-next specific files for 20170705") > > Actually: Fixes: 6797318e623d ("tcp: md5: add an address prefix for key lookup") Applied with correct fixes tag, thanks. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-07-06 9:55 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-07-05 23:58 net/ipv4/tcp_ipv4.c:950:23: sparse: symbol 'tcp_md5_do_lookup_exact' was not declared. Should it be static? kbuild test robot 2017-07-05 23:58 ` [RFC PATCH linus] tcp: md5: tcp_md5_do_lookup_exact() can be static kbuild test robot 2017-07-06 0:27 ` Stephen Rothwell 2017-07-06 8:57 ` Fengguang Wu 2017-07-06 9:55 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).